Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pois
,landuse
,buildings
, assign all name variants and translations, not justname
itself.Note that I initially tried to make "source" an
Enum
, but this turned out to create more difficulties than it solved, as it made it much harder to inject custom, unique sources for testing purposes. It would also make it very difficult to extendvector-datasource
or 3rd party styles to additional data sources. Instead, I've replaced it with aSource
namedtuple
which contains both the short name (e.g:osm
) and the long name that we use as a tag value (e.g:openstreetmap.org
).