Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some RAWR-related TODOs #269

Merged
merged 3 commits into from
Oct 25, 2017
Merged

Fix some RAWR-related TODOs #269

merged 3 commits into from
Oct 25, 2017

Conversation

zerebubuth
Copy link
Member

  • Add support for stations being multipolygon relations (already had support for nodes and ways).
  • When assigning names to one of pois, landuse, buildings, assign all name variants and translations, not just name itself.
  • Remove the hard-coded OSM "source" from RAWR, and make it something that is provided by the table and configurable.

Note that I initially tried to make "source" an Enum, but this turned out to create more difficulties than it solved, as it made it much harder to inject custom, unique sources for testing purposes. It would also make it very difficult to extend vector-datasource or 3rd party styles to additional data sources. Instead, I've replaced it with a Source namedtuple which contains both the short name (e.g: osm) and the long name that we use as a tag value (e.g: openstreetmap.org).

Matt Amos added 3 commits October 24, 2017 16:36
Rather than being hard-coded! This allows configurable sources per table, which we'll be able to use to support WOF, NE, openstreetmapdata and potentially many other sources.
@zerebubuth zerebubuth merged commit d1f699a into master Oct 25, 2017
@zerebubuth zerebubuth deleted the zerebubuth/fix-rawr-todos branch October 25, 2017 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants