Add a tile status command #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandees
approved these changes
Aug 4, 2017
tilequeue/command.py
Outdated
| # now we think we probably have a valid coordinate. go look up | ||
| # whether it exists in various places. | ||
|
|
||
| logger.info("=== %s ===" % (coord_str,)) |
There was a problem hiding this comment.
Logger will do string formatting for you. If you want you can use
logger.info("=== %s ===", coord_str)
There was a problem hiding this comment.
👍
Thanks! I didn't know that. It makes the code much more readable (bc007b3).
rmarianski
approved these changes
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command can be given a list of tiles and it will print out its in-flight, TOI and storage status. This can be helpful while debugging "stuck" tiles, although in the time it took me to write the tool, the issue was probably self-fixed by the gardener.
I had to do some work-around-y stuff to pass the positional
coordsarguments to thecommand_tile_statusfunction, so I'd very much appreciate any recommendations about how that might be done more neatly or cleanly.