Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard coded list of layers in conversion #231

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Remove hard coded list of layers in conversion #231

merged 1 commit into from
Aug 3, 2017

Conversation

rmarianski
Copy link
Member

No description provided.

zerebubuth
zerebubuth approved these changes Aug 3, 2017
View reviewed changes
Copy link
Member

@zerebubuth zerebubuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great way to not need that list of hard-coded layers 😄

@rmarianski
Copy link
Member Author

Yea, originally I don't think I was taking in the layer_data in that function, but eventually I needed it and never updated the hard coded list.

@rmarianski rmarianski merged commit ba172b1 into master Aug 3, 2017
@rmarianski rmarianski deleted the remove-hardcoded-layers branch August 3, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerebubuth zerebubuth zerebubuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmarianski @zerebubuth