Skip to content

[Nvidia][SM121] Add intrin.h include to gemm_mma.h for sm120+ #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

[Nvidia][SM121] Add intrin.h include to gemm_mma.h for sm120+ #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/tl_templates/cuda/gemm_mma.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#include "common.h"
#include "cuda_fp8.h"
#include "intrin.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better modularity, consider including intrin.h directly in the files that require it (e.g., gemm_sm120.h, as mentioned in the PR description) rather than in this more general header. This approach helps to minimize header dependencies and makes it explicit which components rely on the SM90+ intrinsics. If gemm_mma.h itself doesn't use any symbols from intrin.h, moving this include would lead to a cleaner design.


namespace cute {

Expand Down