Skip to content

[CI] Adds pytest-durations for test timing #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
Merged

[CI] Adds pytest-durations for test timing #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5cdef16
[Ci] Adds pytest-durations for test timing
Cunxiao2002 Sep 3, 2025
19e2bc4
Merge branch 'main' into ci_pytest_record
Cunxiao2002 Sep 3, 2025
b1a4cef
add amd ci durations
Cunxiao2002 Sep 3, 2025
00a5fd9
Removes flash_attn installation from CI
Cunxiao2002 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/amd_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
python -m pip install --upgrade pip --no-user
[[ -f requirements-test.txt ]] && \
PIP_NO_BUILD_ISOLATION=1 pip install -r requirements-test.txt --no-user
pip install flash_attn==2.5.8 --no-user --no-build-isolation
touch "$MARKER"
fi

Expand Down Expand Up @@ -116,4 +115,4 @@ jobs:
source "${{ runner.tool_cache }}/${{ env.VENV_DIR }}/bin/activate"
cd testing/python/amd
unset PYTHONPATH
python -m pytest -v test_tilelang_test_amd.py
python -m pytest -v test_tilelang_test_amd.py --durations=0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Do you actually need pytest-durations?

Pytest already supports --durations natively; the extra plugin may be redundant. Please confirm to avoid unnecessary dependencies.

Run locally:

🏁 Script executed:

#!/bin/bash
python -m pytest --help | sed -n '/--durations/,+3p'

Length of output: 317

Remove redundant pytest-durations plugin
pytest already provides --durations and --durations-min options natively; the pytest-durations plugin is therefore unnecessary. Drop it from your CI config and project dependencies.

🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 118-118: no new line character at the end of file

(new-line-at-end-of-file)

🤖 Prompt for AI Agents 
.github/workflows/amd_ci.yml around line 118: the CI job invokes pytest with the
--durations option while the project still lists the pytest-durations plugin as
a dependency; pytest already supports --durations natively so remove the
redundant plugin from CI/dependencies. Update CI/dependency manifests by
removing pytest-durations from requirements/pyproject/poetry.lock (or similar),
and keep the pytest invocation as-is (or optionally replace plugin-specific
flags with native ones like --durations and --durations-min if needed); ensure
tests still run in CI after removing the plugin.

4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,11 @@ jobs:
source "${{ runner.tool_cache }}/${{ env.VENV_DIR }}/bin/activate"
cd examples
unset PYTHONPATH
python -m pytest -n 4 **/test*.py -v -r fE
python -m pytest -n 4 **/test*.py -v -r fE --durations=0

- name: Run tests
run: |
source "${{ runner.tool_cache }}/${{ env.VENV_DIR }}/bin/activate"
cd testing/python
unset PYTHONPATH
python -m pytest -n 4 -v -r fE
python -m pytest -n 4 -v -r fE --durations=0
1 change: 1 addition & 0 deletions requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ dtlib
numpy>=1.23.5
pytest>=6.2.4
pytest_xdist>=2.2.1
pytest-durations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved reproducibility of your test environment, it's a good practice to pin dependency versions. Consider adding a version specifier for pytest-durations. For example, you can use >= to specify a minimum version, which is consistent with other packages in this file like pytest and numpy.

pytest-durations>=0.3.0

packaging>=21.0
PyYAML
tqdm>=4.62.3
Expand Down