Skip to content

[Enhancement] Add shape checking for reduce options #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2025
Merged

[Enhancement] Add shape checking for reduce options #748

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61318ce
Add shape checking for reduce options
kurisu6912 Aug 22, 2025
7880876
Merge branch 'main' of https://github.com/tile-ai/tilelang into kuris…
LeiWang1999 Aug 23, 2025
e295ba1
lint fix
LeiWang1999 Aug 23, 2025
1f6870e
Handle special case reducing into shape-1 tensor
kurisu6912 Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tilelang/language/reduce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ def reduce(buffer: tir.Buffer, out: tir.Buffer, reduce_type: str, dim: int, clea
Returns:
tir.Call: Handle to the reduction operation
"""
# input shape: [X, d, Y], expected output shape: [X, Y] or [X, 1, Y]
expected_shapes = [
buffer.shape[:dim] + buffer.shape[dim + 1:],
buffer.shape[:dim] + [1] + buffer.shape[dim + 1:]
]
if list(out.shape) not in expected_shapes:
expected_shapes_str = ' or '.join(map(str, expected_shapes))
raise ValueError(
f"Invalid reduce output shape, buffer shape is {buffer.shape}, dim is {dim}, "
f"output shape is {out.shape}, expected shapes are {expected_shapes_str}")
buffer = buffer.access_ptr("r")
out = out.access_ptr("w")
return tir.call_intrin(
Expand Down
Loading