Skip to content

[Bugfix] Correctly construct the argument list for atomic add based on the vector size #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

[Bugfix] Correctly construct the argument list for atomic add based on the vector size #1137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adc0bf9
atomic_fix
LeiWang1999 Oct 24, 2025
7e7eea0
atomic_fix
LeiWang1999 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/transform/atomicadd_vectorize.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,21 +231,25 @@ class AtomicAddVectorizeRewriter : public StmtExprMutator {
// Ref: src/tl_templates/cuda/atomic.h::AtomicAdd
const IntImm memory_order =
node->args.size() >= 3 ? Downcast<IntImm>(node->args[2]) : IntImm(0);

Array<PrimExpr> new_args;
Call address_of_dst =
Call(DataType::Handle(), builtin::address_of(), {dst_node});
Call address_of_value =
Call(DataType::Handle(), builtin::address_of(), {value_node});
Array<PrimExpr> new_args;
if (vector_size_ == 4) {
new_args.push_back(StringImm("AtomicAddx4"));
new_args.push_back(address_of_dst);
new_args.push_back(address_of_value);
} else if (vector_size_ == 2) {
new_args.push_back(StringImm("AtomicAddx2"));
new_args.push_back(address_of_dst);
new_args.push_back(address_of_value);
} else {
new_args.push_back(StringImm("AtomicAdd"));
new_args.push_back(dst_node);
new_args.push_back(value_node);
}
new_args.push_back(address_of_dst);
new_args.push_back(address_of_value);

new_args.push_back(memory_order);

Call new_call =
Expand Down
Loading