Skip to content

Conversation

@Rachmanino
Copy link
Collaborator

@Rachmanino Rachmanino commented Oct 21, 2025

This pull request removes calls to tilelang.disable_cache() from multiple example scripts across the repository. This cleanup helps ensure that the examples use the default caching behavior of the tilelang library, which can improve performance and consistency. No other functional changes are introduced.

Removals of cache disabling:

  • Removed tilelang.disable_cache() from various example files in the examples/blocksparse_attention, examples/cast, examples/deepseek_mla/amd, examples/elementwise, examples/flash_attention, examples/gdn, examples/gemm_sm100, examples/grouped_gemm, examples/minference, and examples/warp_specialize directories. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]
  • Also removed tilelang.disable_cache() from the maintenance script maint/precision/compare_ops.py.

Summary by CodeRabbit

  • Chores
    • Restored default caching across multiple example scripts and tests by removing explicit cache-disable calls; behavior and APIs unchanged, with potential runtime/performance improvements during example runs and test execution.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025

Walkthrough

This PR removes top-level calls to tilelang.disable_cache() across multiple example and test modules, reverting modules to rely on default TileLang caching behavior; no other functional or API changes were introduced.

Changes

Cohort / File(s) Summary
Blocksparse & attention examples
examples/blocksparse_attention/example_tilelang_sparse_gqa_decode_paged.py, examples/flash_attention/example_gqa_bwd_tma_reduce_varlen.py, examples/minference/example_vertical_slash_sparse_attn.py
Removed top-level tilelang.disable_cache() calls (one file only had a commented-out call removed).
Cast & elementwise examples
examples/cast/example_per_token_cast_to_fp8.py, examples/elementwise/example_elementwise_add.py
Removed top-level tilelang.disable_cache() calls at module import time.
DeepSeek MLA benchmark
examples/deepseek_mla/amd/benchmark_mla_decode_amd_tilelang.py
Removed initial tilelang.disable_cache() call at module import.
GDN examples
examples/gdn/example_chunk_delta_bwd.py, examples/gdn/example_chunk_delta_h.py, examples/gdn/example_chunk_o.py, examples/gdn/example_chunk_o_bwd.py, examples/gdn/example_chunk_scaled_dot_kkt.py, examples/gdn/example_cumsum.py, examples/gdn/example_wy_fast.py, examples/gdn/example_wy_fast_bwd_split.py
Removed tilelang.disable_cache() calls from module initialization across these files.
GEMM examples
examples/gemm_sm100/gemm_tcgen5mma.py, examples/grouped_gemm/example_grouped_gemm_bwd.py
Removed top-level tilelang.disable_cache() calls and adjacent blank-line changes.
Warp-specialize examples
examples/warp_specialize/example_warp_specialize_flashmla.py, examples/warp_specialize/example_warp_specialize_gemm_copy_gemm_0_1.py, examples/warp_specialize/example_warp_specialize_gemm_softpipe_stage2.py
Removed tilelang.disable_cache() from module or main() initialization.
Maintenance & tests
maint/precision/compare_ops.py, testing/python/fastmath/test_mathops_fastmath.py, testing/python/tilelibrary/test_tilelang_tilelibrary_gemm_sp.py
Removed tilelang.disable_cache() from module init or __main__ guard in tests/maintenance scripts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Changes are homogeneous (removal of a single top-level call across files) with minimal code density; review should focus on ensuring no file relied on the prior disabled-cache side effect.

Possibly related PRs

Suggested reviewers

  • LeiWang1999
  • tzj-fxz

Poem

🐇 I hopped through code at break of day,
I nudged one call that got in the way.
Caches wake up, no longer suppressed,
Examples breathe easy, ready to test. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "[Cleanup] Remove tilelang.disable_cache() calls from examples and tests" accurately describes the primary change across all modified files. The raw summary confirms that the changeset consistently removes calls to tilelang.disable_cache() across 20+ files in various example directories and maintenance/test files, which aligns precisely with the title. The title is concise, specific, and clearly conveys the cleanup nature of the change without unnecessary vagueness or noise, making it easy for teammates reviewing history to understand the intent.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cc5ddf and 83b34a8.

📒 Files selected for processing (2)
  • examples/gdn/example_chunk_delta_bwd.py (0 hunks)
  • testing/python/tilelibrary/test_tilelang_tilelibrary_gemm_sp.py (0 hunks)
💤 Files with no reviewable changes (2)
  • examples/gdn/example_chunk_delta_bwd.py
  • testing/python/tilelibrary/test_tilelang_tilelibrary_gemm_sp.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test for Python 3.12 with Metal (on macos-latest)
  • GitHub Check: Test for Python 3.12 with ROCm-6.3 (on self-hosted-amd)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LeiWang1999 LeiWang1999 merged commit 0c7e741 into tile-ai:main Oct 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants