This repository was archived by the owner on Apr 4, 2019. It is now read-only.
Fix issue with duplicate keys and last item. #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2015
Merged
We are using `renderState.handledMorphs` as a way to know if a given key is duplicated or not (if it is duplicated we use a binning strategy to prevent errors), but we were setting `handleMorphs[key]` to `null` when the given morph was the last item in the list. The fix is to keep `renderAndCleanup` and `yieldItem` using the same mechanism to know of the handled morphs (both should check via `key in handledMorphs`).
rwjblue
force-pushed
the
fix-last-morph-duplicate-key
branch
from
b83e3ad to
63c0a4a
Compare
mmun
added a commit
that referenced
this pull request
Aug 3, 2015
Fix issue with duplicate keys and last item.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
renderState.handledMorphsas a way to know if a given key is duplicated or not (if it is duplicated we use a binning strategy to prevent errors), but we were settinghandleMorphs[key]tonullwhen the given morph was the last item in the list.The fix is to keep
renderAndCleanupandyieldItemusing the same mechanism to know of the handled morphs (both should check viakey in handledMorphs).This is the fix for emberjs/ember.js#11949.