scikit-build-core port#21
Merged
Merged
Conversation
Rename python package dir to "src" to be different from installed package.
Editable install is broken since Setuptools 64 pypa/setuptools#3504 Not supported by scikit-build scikit-build/scikit-build#740 scikit-build/scikit-build#770 scikit-build/scikit-build#939
Vulnerable Libraries (1)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
|
Bito Automatic Review Skipped - Files Excluded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes of #20 + port to scikit-build-core.
pyproject.tomlis moved to the root. Editable install is supported.setuptoolsis dropped. Simplify cmake scripts.Broken codacy action is dropped.
ilammy/msvc-dev-cmdaction is broken. So, bundle fixed version of it until ilammy/msvc-dev-cmd#94 and ilammy/msvc-dev-cmd#95 are merged (or not).cibuildwheelandrepairwheelare used to build wheels as recommended inscikit-build-core's documentation. Now only the targets that were there before are being built. Then we can try adding macosx, arm, etc.Summary by Bito