mvcc: fix gc bug. #1350
Merged
mvcc: fix gc bug. #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
|
PTAL @BusyJay |
BusyJay
reviewed
Nov 24, 2016
| while let Some((commit, write)) = try!(self.reader.seek_write(key, ts)) { | ||
| if self.write_size >= MAX_TXN_WRITE_SIZE { | ||
| // Cannot remove latest delete when we haven't iterate all versions. | ||
| latest_delete = None; | ||
| break; | ||
| } | ||
| if !remove_older { |
There was a problem hiding this comment.
Can you reduce the if ... {} else {} levels by if ... { ... continue}? This condition block is too long and hard to read.
|
LGTM |
1 similar comment
|
LGTM |
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
May 31, 2024
Signed-off-by: Ping Yu <yuping@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we stop iterating all mvcc versions due to
MAX_TXN_WRITE_SIZElimit, we should not delete latest delete before safePoint./cc @siddontang @zhangjinpeng1987 @ngaut