Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

causal_ts: add async func for CausalTsProvider #13429

Merged
merged 7 commits into from
Sep 20, 2022
Merged

causal_ts: add async func for CausalTsProvider #13429

merged 7 commits into from
Sep 20, 2022

Conversation

zeminzhou
Copy link
Contributor

@zeminzhou zeminzhou commented Sep 7, 2022 •
edited by pingyu
Loading

Signed-off-by: zeminzhou zhouzemin@pingcap.com

What is changed and how it works?

Issue Number: Close #13428

What's Changed:

Add async func for get_ts & flush for CausalTsProvider.

Check List

Tests

  • Unit test
  • Integration test

Release note 

Add asynchronous methods for `CausalTsProvider`.

@zeminzhou
add async for causal ts
56caaf4 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • haojinming
  • pingyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2022
@zeminzhou
Copy link
Contributor Author

/cc @pingyu @haojinming @iosmanthus

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2022
@pingyu pingyu closed this Sep 20, 2022
@pingyu pingyu reopened this Sep 20, 2022
@zeminzhou
Merge branch 'master' into async-causal-ts
8dcb530 
Signed-off-by: zzm <zhouzemin@pingcap.com>
@zeminzhou
Merge branch 'master' into async-causal-ts
47a2f8c 
Signed-off-by: zzm <zhouzemin@pingcap.com>
@zeminzhou
fix clippy
50b68fd 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@zeminzhou
Merge branch 'master' into async-causal-ts
b83d447
@zeminzhou
fix format
36a5db1 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
pingyu
pingyu approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 20, 2022
haojinming
haojinming approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@haojinming haojinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 20, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2022
haojinming
haojinming reviewed Sep 20, 2022
View reviewed changes
components/causal_ts/src/lib.rs
#[enum_dispatch]
pub trait CausalTsProvider: Send + Sync {
/// Get a new timestamp.
fn get_ts(&self) -> Result<TimeStamp>;
fn get_ts(&self) -> Result<TimeStamp> {
Copy link
Contributor

@haojinming haojinming Sep 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change the caller in Storage::get_causal_ts to async, or in next PR.

@pingyu
Copy link
Contributor

pingyu commented Sep 20, 2022

/merge

@ti-chi-bot
Copy link
Member

@pingyu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1a27419

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2022
@ti-chi-bot ti-chi-bot merged commit 3d075ab into tikv:master Sep 20, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Sep 20, 2022
@zeminzhou zeminzhou deleted the async-causal-ts branch October 18, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haojinming haojinming haojinming approved these changes

@pingyu pingyu pingyu approved these changes

@iosmanthus iosmanthus Awaiting requested review from iosmanthus

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

async func for CausalTsProvider
4 participants
@zeminzhou @ti-chi-bot @pingyu @haojinming