Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore: calculate slow score periodically #10674

Merged
merged 12 commits into from
Aug 6, 2021
Merged

raftstore: calculate slow score periodically #10674

merged 12 commits into from
Aug 6, 2021

Conversation

5kbpers
Copy link
Member

@5kbpers 5kbpers commented Aug 6, 2021

What problem does this PR solve?

Problem Summary:

Address #10539.

What is changed and how it works?

What's Changed:

  • Add a tick to pd worker, inspect raftstore latency and calculate slow score periodically.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note 

Introduce a mechanism to detect slow tikv store

@5kbpers
raftstore: calculate slow score periodically
bc36833 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hicqu
  • hunterlxt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 6, 2021
@5kbpers 5kbpers requested a review from yiwu-arbug August 6, 2021 03:00
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2021
@5kbpers 5kbpers requested review from NingLin-P and hicqu August 6, 2021 03:00
@5kbpers
fix test
b46feb1 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@5kbpers
format
6910698 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@5kbpers
Copy link
Member Author

5kbpers commented Aug 6, 2021

/run-all-tests

@5kbpers
fix metric name
d2c929a 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@5kbpers
address comment
ba84cf8 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@5kbpers
remove spaces
206f015 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@5kbpers
add comment
d046257 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@hicqu
Copy link
Contributor

hicqu commented Aug 6, 2021

LGTM.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2021
@5kbpers
format
e6ab95d 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
hunterlxt
hunterlxt reviewed Aug 6, 2021
View reviewed changes
components/raftstore/src/store/worker/pd.rs
@@ -496,6 +507,89 @@ fn hotspot_query_num_report_threshold() -> u64 {
HOTSPOT_QUERY_RATE_THRESHOLD * 10
}

struct SlowScore {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's better to place a description of the motivation and calculation method of slow score

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 6, 2021
@hicqu
Copy link
Contributor

hicqu commented Aug 6, 2021

/merge

@ti-chi-bot
Copy link
Member

@hicqu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2021
@hunterlxt hunterlxt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2021
@hicqu
Copy link
Contributor

hicqu commented Aug 6, 2021

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2021
@5kbpers
address comment
4c840ff 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@5kbpers
Merge remote-tracking branch 'upstream/master' into slow-store
970975f 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@5kbpers
Copy link
Member Author

5kbpers commented Aug 6, 2021

/merge

@ti-chi-bot
Copy link
Member

@5kbpers: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 970975f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2021
@5kbpers
format
90c42a6 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2021
@5kbpers
Copy link
Member Author

5kbpers commented Aug 6, 2021

/merge

@ti-chi-bot
Copy link
Member

@5kbpers: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 90c42a6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2021
@hicqu hicqu removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2021
@ti-chi-bot ti-chi-bot merged commit 8fc1d21 into tikv:master Aug 6, 2021
@5kbpers 5kbpers mentioned this pull request Aug 9, 2021
Merged
12 tasks
@BusyJay BusyJay mentioned this pull request Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu hicqu approved these changes

@hunterlxt hunterlxt hunterlxt approved these changes

@yiwu-arbug yiwu-arbug Awaiting requested review from yiwu-arbug

@NingLin-P NingLin-P Awaiting requested review from NingLin-P

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@5kbpers @ti-chi-bot @hicqu @hunterlxt