update rocksdb and titan by liyishuai · Pull Request #850 · tikv/rust-rocksdb

liyishuai · 2026-04-28T11:10:51Z

to include tikv/rocksdb#429 and tikv/titan#339

Summary by CodeRabbit

Chores
- Updated RocksDB dependency to a newer upstream version.
- Updated Titan dependency to a newer upstream version.
- No public APIs or exported interfaces were changed; behavior and integrations remain compatible.

ti-chi-bot · 2026-04-28T11:11:01Z

Hi @liyishuai. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-04-28T11:11:02Z

Welcome @liyishuai!

It looks like this is your first PR to tikv/rust-rocksdb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to tikv/rust-rocksdb. 😃

coderabbitai · 2026-04-28T11:11:06Z

📝 Walkthrough

Walkthrough

Submodule references for two native libraries were advanced: librocksdb_sys/rocksdb now points to a new RocksDB commit, and librocksdb_sys/libtitan_sys/titan now points to a new Titan commit.

Changes

Cohort / File(s)	Summary
RocksDB submodule `librocksdb_sys/rocksdb`	Updated submodule commit reference to a newer upstream RocksDB revision (single-line commit pointer change).
Titan submodule `librocksdb_sys/libtitan_sys/titan`	Updated submodule commit reference to a newer upstream Titan revision (single-line commit pointer change).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hopped through commits, light and quick,
Two submodules nudged with a joyful kick,
RocksDB and Titan moved ahead,
Fresh hashes tucked into my bed,
A tiny hop for code, a carrot for the fix! 🥕✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'update rocksdb and titan' directly describes the main changes—updating both the rocksdb and titan submodules to new commits.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Yishuai Li <yishuai.li@pingcap.com>

Connor1996

LGTM

ti-chi-bot · 2026-04-28T22:15:31Z

[LGTM Timeline notifier]

Timeline:

2026-04-28 22:15:31.443353648 +0000 UTC m=+2722536.648713725: ☑️ agreed by Connor1996.

liyishuai · 2026-04-28T22:19:37Z

/retest

ti-chi-bot · 2026-04-28T22:19:52Z

@liyishuai: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-04-28T23:03:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, v01dstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Connor1996,v01dstar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lhy1024 · 2026-04-29T01:35:34Z

/ok-to-test

bufferflies · 2026-04-29T01:50:25Z

/ok-to-test

liyishuai · 2026-04-29T07:30:51Z

/retest

) ## Problem `openssl-sys` v0.9.114 (released ~April 2026) dropped support for OpenSSL < 1.1.0. The current CentOS 7 builder image installs `openssl-devel` from the CentOS 7 repos, which provides OpenSSL **1.0.2k** — now rejected at compile time with: > "This crate is only compatible with OpenSSL (version 1.1.0, 1.1.1, 3.x, or 4.x), but a different version of OpenSSL was found." This breaks the `encryption` feature build for **all PRs** targeting `tikv/rust-rocksdb` (confirmed also broken on PR #849, an unrelated change). Upstream issue: tikv/rust-rocksdb#850 ## Fix Switch all three jobs (`pull-rust-rocksdb-lint`, `pull-rust-rocksdb-test-x86`, `pull-rust-rocksdb-test-arm`) to the same Rocky Linux 8 builder image that `tikv/tikv` latest presubmits already use (`v2026.3.22-3-g892e449`). Rocky Linux 8 ships OpenSSL 1.1.1 and a modern GCC system-wide, so: - `yum install -y openssl-devel` is removed (pre-installed in the image) - The `devtoolset-8` source block is removed (system GCC is sufficient) - The CentOS-specific `llvm-toolset-7.0` SCL install is replaced with `dnf install -y clang-tools-extra` ## Precedent `tikv/tikv` latest presubmits already run on this image (see PR #4383). Signed-off-by: Yishuai Li <yishuai.li@pingcap.com>

liyishuai · 2026-04-29T10:55:48Z

/retest

Copilot AI review requested due to automatic review settings April 28, 2026 11:10

ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. labels Apr 28, 2026

ti-chi-bot Bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 28, 2026

ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2026

Copilot started reviewing on behalf of liyishuai April 28, 2026 11:11 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

update rocksdb and titan

94db8b9

Signed-off-by: Yishuai Li <yishuai.li@pingcap.com>

liyishuai force-pushed the update-rocksdb branch from 5f7fa66 to 94db8b9 Compare April 28, 2026 17:26

liyishuai changed the title ~~update rocksdb~~ update rocksdb and titan Apr 28, 2026

Connor1996 approved these changes Apr 28, 2026

View reviewed changes

ti-chi-bot Bot added the lgtm label Apr 28, 2026

ti-chi-bot Bot added the approved label Apr 28, 2026

v01dstar approved these changes Apr 28, 2026

View reviewed changes

ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 29, 2026

liyishuai mentioned this pull request Apr 29, 2026

fix(tikv/rust-rocksdb): migrate CI from CentOS 7 to Rocky Linux 8 PingCAP-QE/ci#4564

Merged

ti-chi-bot Bot merged commit c9aefbe into tikv:master Apr 29, 2026
9 checks passed

liyishuai deleted the update-rocksdb branch April 29, 2026 11:19

Conversation

liyishuai commented Apr 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

ti-chi-bot Bot commented Apr 28, 2026

Uh oh!

ti-chi-bot Bot commented Apr 28, 2026

Uh oh!

coderabbitai Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Connor1996 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Apr 28, 2026

[LGTM Timeline notifier]

Uh oh!

liyishuai commented Apr 28, 2026

Uh oh!

ti-chi-bot Bot commented Apr 28, 2026

Uh oh!

ti-chi-bot Bot commented Apr 28, 2026

Uh oh!

lhy1024 commented Apr 29, 2026

Uh oh!

bufferflies commented Apr 29, 2026

Uh oh!

liyishuai commented Apr 29, 2026

Uh oh!

liyishuai commented Apr 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

liyishuai commented Apr 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 28, 2026 •

edited

Loading