Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change c.h and c.cc for bindgen ffi #401

Merged

Conversation

fredchenbj
Copy link
Member

this pr is extraced from pr #398 to make code review easier.

it make some changes of c.h and c.cc, for example, 1) change bool to unsigned char; 2) add declarations of some struct; 3) fix some mistakes.

those changes have been tested by bindgen in pr #398 .

Signed-off-by: fredchenbj cfworking@163.com

Signed-off-by: fredchenbj <cfworking@163.com>
Connor1996
Connor1996 previously approved these changes Dec 9, 2019
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Connor1996
Copy link
Member

Please fix the format

1 similar comment
@Connor1996
Copy link
Member

Please fix the format

Signed-off-by: fredchenbj <cfworking@163.com>
@fredchenbj fredchenbj force-pushed the fredchenbj/change_c_for_bindgen_ffi branch from 4bc7f72 to 6432990 Compare December 10, 2019 06:10
Signed-off-by: fredchenbj <cfworking@163.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants