Enhance: replace unwrap() with Result to handle errors in register-* macros
#480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval-exec
changed the title
unwrap() with Result to handle errors in register-* macros
Signed-off-by: Eval EXEC <execvy@gmail.com>
eval-exec
force-pushed
the
enhance/better-error-handle
branch
from
7ea049f to
332edc3
Compare
|
https://github.com/tikv/rust-prometheus/actions/runs/4349482473/jobs/7603874911 The CI action failed, I think we should upgrade the rust toolchain's version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
register_*macro to use theand_thenmethod instead ofunwrapto handle errors.The purpose of this change is to improve error handling and make the code more robust.