TiKV Rust Client RFC #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunxiaoguang
force-pushed
the
tikv-client-rust
branch
from
96bd8bd
to
cf0cd50
Compare
solotzg
reviewed
Oct 25, 2018
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
sunxiaoguang
force-pushed
the
tikv-client-rust
branch
from
cf0cd50
to
7419c9b
Compare
siddontang
reviewed
Oct 30, 2018
|
PTAL @tikv/pingcap-i18n |
lilin90
reviewed
Oct 31, 2018
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
Hoverbear
reviewed
Oct 31, 2018
|
Great job @sunxiaoguang, thanks for tackling this huge task! My hero. 😂 |
rleungx
reviewed
Nov 2, 2018
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
lilin90
reviewed
Nov 2, 2018
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
sunxiaoguang
force-pushed
the
tikv-client-rust
branch
from
a48509c
to
e82ac4e
Compare
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
gregwebs
reviewed
Nov 12, 2018
|
Hi friends! Are there any remaining points anyone would like to see addressed in this PR? We will likely amend this RFC in the future to reflect the final function signatures etc in the implemented code. That will be a different PR. |
|
Now that we've seen tikv/client-rust#14 merged we can revisit & update this document. |
* add schedule limit design Signed-off-by: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update 2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> * Fix lints Signed-off-by: Hoverbear <operator@hoverbear.org> * Update text/2018-09-17-schedule-limit.md Signed-off-by: A. Hobden <operator@hoverbear.org> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: A. Hobden <operator@hoverbear.org> Co-Authored-By: disksing <i@disksing.com> * use Region instead of region Signed-off-by: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: Caitin <34535727+caitinchen@users.noreply.github.com> Co-Authored-By: disksing <i@disksing.com> Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
force-pushed
the
tikv-client-rust
branch
3 times, most recently
from
e857c87
to
041fe9f
Compare
|
Trying to resolve the DCO problem on this PR. :) |
* unified log format Signed-off-by: Wenxuan Shi <hi@breeswish.org> Signed-off-by: Ana Hobden <operator@hoverbear.org>
* introduce PD simulator Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
force-pushed
the
tikv-client-rust
branch
from
041fe9f
to
252eb33
Compare
Closed
sunxiaoguang
added a commit
to tikv/tikv
that referenced
this pull request
Mar 19, 2019
My name is Sun Xiaoguang from Zhihu, where I help make a BigTable like system focusd on OLTP that is using TiKV. I've been contributing to TiKV and the library ecosystem for around a year now. I first touched the TiKV codebase since around March 2018. As part of my involvement with the project I've contributed several improvements to the TiKV Project: * [Added raw batch put/get/delete/scan](pingcap/kvproto#244) * [Changed `get_region` and `get_region_info` to use a common implementation](#3521) * [Print help message when starting tikv-ctl without argument](#3531) * [Clean up unused #[allow] directives](#3553) I also am the first and primary author of the [TiKV Rust Client](https://github.com/tikv/client-rust). You can see related PRs for that here: * [TiKV Rust Client RFC](tikv/rfcs#7) * [The initial version of Raw KV Implementation](tikv/client-rust#14) * [Change `raw::Client::get` to return `Option<Value>`](tikv/client-rust#24) * [Remove cf and batch_scan from `example/raw.rs`](tikv/client-rust#21) I also made the first PR to the mock TiKV project: [A basic implementation of mock TiKV API surface](tikv/mock-tikv#1) As part of my involvement, the TiKV team inquired if I was interested in becoming a maintainer for the project. This PR adds me to the list of maintainers. I have read and understand the expectations of maintainers described in the `GOVERNANCE.md` file.
sunxiaoguang
added a commit
to tikv/tikv
that referenced
this pull request
Mar 19, 2019
My name is Sun Xiaoguang from Zhihu, where I help make a BigTable like system focusd on OLTP that is using TiKV. I've been contributing to TiKV and the library ecosystem for around a year now. I first touched the TiKV codebase since around March 2018. As part of my involvement with the project I've contributed several improvements to the TiKV Project: * [Added raw batch put/get/delete/scan](pingcap/kvproto#244) * [Changed `get_region` and `get_region_info` to use a common implementation](#3521) * [Print help message when starting tikv-ctl without argument](#3531) * [Clean up unused #[allow] directives](#3553) I also am the first and primary author of the [TiKV Rust Client](https://github.com/tikv/client-rust). You can see related PRs for that here: * [TiKV Rust Client RFC](tikv/rfcs#7) * [The initial version of Raw KV Implementation](tikv/client-rust#14) * [Change `raw::Client::get` to return `Option<Value>`](tikv/client-rust#24) * [Remove cf and batch_scan from `example/raw.rs`](tikv/client-rust#21) I also made the first PR to the mock TiKV project: [A basic implementation of mock TiKV API surface](tikv/mock-tikv#1) As part of my involvement, the TiKV team inquired if I was interested in becoming a maintainer for the project. This PR adds me to the list of maintainers. I have read and understand the expectations of maintainers described in the `GOVERNANCE.md` file. Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
sunxiaoguang
added a commit
to tikv/tikv
that referenced
this pull request
Mar 20, 2019
My name is Sun Xiaoguang from Zhihu, where I help make a BigTable like system focusd on OLTP that is using TiKV. I've been contributing to TiKV and the library ecosystem for around a year now. I first touched the TiKV codebase since around March 2018. As part of my involvement with the project I've contributed several improvements to the TiKV Project: * [Added raw batch put/get/delete/scan](pingcap/kvproto#244) * [Changed `get_region` and `get_region_info` to use a common implementation](#3521) * [Print help message when starting tikv-ctl without argument](#3531) * [Clean up unused #[allow] directives](#3553) I also am the first and primary author of the [TiKV Rust Client](https://github.com/tikv/client-rust). You can see related PRs for that here: * [TiKV Rust Client RFC](tikv/rfcs#7) * [The initial version of Raw KV Implementation](tikv/client-rust#14) * [Change `raw::Client::get` to return `Option<Value>`](tikv/client-rust#24) * [Remove cf and batch_scan from `example/raw.rs`](tikv/client-rust#21) I also made the first PR to the mock TiKV project: [A basic implementation of mock TiKV API surface](tikv/mock-tikv#1) As part of my involvement, the TiKV team inquired if I was interested in becoming a maintainer for the project. This PR adds me to the list of maintainers. I have read and understand the expectations of maintainers described in the `GOVERNANCE.md` file. Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
siddontang
pushed a commit
to tikv/tikv
that referenced
this pull request
Mar 26, 2019
* Title: Add @sunxiaoguang to MAINTAINERS.md My name is Sun Xiaoguang from Zhihu, where I help make a BigTable like system focusd on OLTP that is using TiKV. I've been contributing to TiKV and the library ecosystem for around a year now. I first touched the TiKV codebase since around March 2018. As part of my involvement with the project I've contributed several improvements to the TiKV Project: * [Added raw batch put/get/delete/scan](pingcap/kvproto#244) * [Changed `get_region` and `get_region_info` to use a common implementation](#3521) * [Print help message when starting tikv-ctl without argument](#3531) * [Clean up unused #[allow] directives](#3553) I also am the first and primary author of the [TiKV Rust Client](https://github.com/tikv/client-rust). You can see related PRs for that here: * [TiKV Rust Client RFC](tikv/rfcs#7) * [The initial version of Raw KV Implementation](tikv/client-rust#14) * [Change `raw::Client::get` to return `Option<Value>`](tikv/client-rust#24) * [Remove cf and batch_scan from `example/raw.rs`](tikv/client-rust#21) I also made the first PR to the mock TiKV project: [A basic implementation of mock TiKV API surface](tikv/mock-tikv#1) As part of my involvement, the TiKV team inquired if I was interested in becoming a maintainer for the project. This PR adds me to the list of maintainers. I have read and understand the expectations of maintainers described in the `GOVERNANCE.md` file. Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
* Title: Add @sunxiaoguang to MAINTAINERS.md My name is Sun Xiaoguang from Zhihu, where I help make a BigTable like system focusd on OLTP that is using TiKV. I've been contributing to TiKV and the library ecosystem for around a year now. I first touched the TiKV codebase since around March 2018. As part of my involvement with the project I've contributed several improvements to the TiKV Project: * [Added raw batch put/get/delete/scan](pingcap/kvproto#244) * [Changed `get_region` and `get_region_info` to use a common implementation](tikv#3521) * [Print help message when starting tikv-ctl without argument](tikv#3531) * [Clean up unused #[allow] directives](tikv#3553) I also am the first and primary author of the [TiKV Rust Client](https://github.com/tikv/client-rust). You can see related PRs for that here: * [TiKV Rust Client RFC](tikv/rfcs#7) * [The initial version of Raw KV Implementation](tikv/client-rust#14) * [Change `raw::Client::get` to return `Option<Value>`](tikv/client-rust#24) * [Remove cf and batch_scan from `example/raw.rs`](tikv/client-rust#21) I also made the first PR to the mock TiKV project: [A basic implementation of mock TiKV API surface](tikv/mock-tikv#1) As part of my involvement, the TiKV team inquired if I was interested in becoming a maintainer for the project. This PR adds me to the list of maintainers. I have read and understand the expectations of maintainers described in the `GOVERNANCE.md` file. Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
|
@sunxiaoguang Seems this RFC is out-of-date with existing tikv/rust-client, would you mind to update it or just clost it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the API design for a Rust client for TiKV.