-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divide src/progress.rs into mods #188
Divide src/progress.rs into mods #188
Conversation
Signed-off-by: Fullstop000 <fullstop1005@gmail.com>
Signed-off-by: Fullstop000 <fullstop1005@gmail.com>
Signed-off-by: Fullstop000 <fullstop1005@gmail.com>
Hi @Fullstop000 ! I think this is a step in the right direction. :) In the future we may want to split things up more, and there are certainly other parts of Raft that could have this treatment, but I appreciate you choosing to do this in a bite sized chunk. Please take a moment to fix the merge conflict if you could. |
…e125_divide_progress_into_mods Signed-off-by: Fullstop000 <fullstop1005@gmail.com> # Conflicts: # src/progress/progress_set.rs
PTAL @BusyJay |
Signed-off-by: Fullstop000 <fullstop1005@gmail.com>
…e125_divide_progress_into_mods Signed-off-by: Fullstop000 <fullstop1005@gmail.com> # Conflicts: # src/progress/progress_set.rs # src/raft.rs
…ds' into issue125_divide_progress_into_mods
Signed-off-by: Fullstop000 <fullstop1005@gmail.com>
@BusyJay Was your last review a green approved check? :) Can you give another? |
Thanks for your contribution! |
#125
The original
src/progress.rs
is divided intosrc/progress/{mod.rs, infights.rs, progress_set.rs}