mcs: enforce keyspace for Resource Group CRUD #9342
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
ti-chi-bot
bot
added
release-note-none
client/resource_manager_client.go
Outdated
| if keyspaceID == constants.NullKeyspaceID { | ||
| return []byte(groupSettingsPathPrefix) | ||
| } | ||
| // TODO: Do we need to consider isSingleGroupByKeyspace? |
There was a problem hiding this comment.
I am not sure for it
There was a problem hiding this comment.
@nolouch Could you please take a look if this change is still compatible with serverless?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9342 +/- ##
==========================================
+ Coverage 76.02% 76.06% +0.03%
==========================================
Files 475 476 +1
Lines 74080 74192 +112
==========================================
+ Hits 56320 56431 +111
+ Misses 14241 14237 -4
- Partials 3519 3524 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
What problem does this PR solve?
Issue Number: Ref #9296
What is changed and how does it work?
Check List
Tests
Release note