-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make TestLabelerRuleTTL stable #8723
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: okJiang <819421878@qq.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8723 +/- ##
==========================================
- Coverage 71.70% 71.69% -0.02%
==========================================
Files 517 517
Lines 67450 67457 +7
==========================================
- Hits 48364 48362 -2
- Misses 15521 15532 +11
+ Partials 3565 3563 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -341,7 +341,7 @@ func TestKeyRange(t *testing.T) { | |||
func TestLabelerRuleTTL(t *testing.T) { | |||
re := require.New(t) | |||
store := endpoint.NewStorageEndpoint(kv.NewMemoryKV(), nil) | |||
labeler, err := NewRegionLabeler(context.Background(), store, time.Millisecond*10) | |||
labeler, err := NewRegionLabeler(context.Background(), store, time.Minute) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be too long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case don't need to test GC.
What problem does this PR solve?
Issue Number: Close #8687
What is changed and how does it work?
see #8687 (comment)
Check List
Tests
Release note