Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add linters to organize import dependency #8532

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 15, 2024

What problem does this PR solve?

Issue Number: ref #4322.

What is changed and how does it work?

Enable some linters to prevent importing unexpected dependencies and formatting issues.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Aug 15, 2024
@rleungx rleungx changed the title *: add a linter to organize import dependency *: add linters to organize import dependency Aug 15, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 15, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-15 06:09:25.803926228 +0000 UTC m=+421050.507395870: ☑️ agreed by JmPotato.
  • 2024-08-15 06:12:55.862310145 +0000 UTC m=+421260.565779785: ☑️ agreed by HuSharp.

Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuSharp,JmPotato,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (cc2900c) to head (d5a8fff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8532      +/-   ##
==========================================
- Coverage   77.67%   77.53%   -0.14%     
==========================================
  Files         474      474              
  Lines       61866    61862       -4     
==========================================
- Hits        48055    47966      -89     
- Misses      10272    10356      +84     
- Partials     3539     3540       +1     
Flag Coverage Δ
unittests 77.53% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 1b8fc6a into tikv:master Aug 15, 2024
25 of 26 checks passed
@rleungx rleungx deleted the depguard branch August 15, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants