Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: enable G601 for gosec #8398

Merged
merged 2 commits into from
Jul 16, 2024
Merged

*: enable G601 for gosec #8398

merged 2 commits into from
Jul 16, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 15, 2024

What problem does this PR solve?

Issue Number: ref #4322

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.18%. Comparing base (b3697fa) to head (61f749e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8398      +/-   ##
==========================================
- Coverage   77.30%   77.18%   -0.12%     
==========================================
  Files         471      471              
  Lines       61679    61630      -49     
==========================================
- Hits        47679    47572     -107     
- Misses      10413    10471      +58     
  Partials     3587     3587              

Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-15 10:19:38.133140508 +0000 UTC m=+262800.124081979: ☑️ agreed by lhy1024.
  • 2024-07-16 03:23:56.518802592 +0000 UTC m=+324258.509744063: ☑️ agreed by nolouch.

Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 61f749e link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rleungx
Copy link
Member Author

rleungx commented Jul 16, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit ca179e6 into tikv:master Jul 16, 2024
24 of 25 checks passed
@rleungx rleungx deleted the enable-G601 branch July 16, 2024 03:34
@okJiang
Copy link
Member

okJiang commented Jul 17, 2024

link #4322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants