Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: enable error check for mcs, keyspace and labeler #8288

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 14, 2024

What problem does this PR solve?

Issue Number: Ref #1919.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 14, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2024
@rleungx rleungx changed the title *: enable error check for mcs and labeler *: enable error check for mcs, keyspace and labeler Jun 14, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.31%. Comparing base (463aee9) to head (e541372).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8288      +/-   ##
==========================================
- Coverage   77.39%   77.31%   -0.08%     
==========================================
  Files         470      470              
  Lines       61387    61392       +5     
==========================================
- Hits        47508    47464      -44     
- Misses      10315    10372      +57     
+ Partials     3564     3556       -8     
Flag Coverage Δ
unittests 77.31% <14.28%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-14 09:56:40.146028361 +0000 UTC m=+717754.199340283: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 14, 2024
@HuSharp HuSharp added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2024
@rleungx
Copy link
Member Author

rleungx commented Jun 14, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit c1d422e into tikv:master Jun 14, 2024
18 of 20 checks passed
@rleungx rleungx deleted the enable-more branch June 14, 2024 10:09
@HuSharp HuSharp added type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. and removed type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants