Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: make TestFallbackTSOConsistency stable #7408

Merged
merged 2 commits into from
Nov 22, 2023
Merged

tests: make TestFallbackTSOConsistency stable #7408

merged 2 commits into from
Nov 22, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 21, 2023

What problem does this PR solve?

Issue Number: Close #7407

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 21, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2023
@lhy1024
tests: make TestFallbackTSOConsistency stable
9f2ccf2 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
replace pd with tu
0afb184 
Signed-off-by: lhy1024 <admin@liudos.us>
JmPotato
JmPotato reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use testutil.Eventually?

JmPotato
JmPotato reviewed Nov 22, 2023
View reviewed changes
tests/integrations/tso/consistency_test.go
@@ -27,7 +27,7 @@ import (
tso "github.com/tikv/pd/pkg/mcs/tso/server"
tsopkg "github.com/tikv/pd/pkg/tso"
"github.com/tikv/pd/pkg/utils/tempurl"
pd "github.com/tikv/pd/pkg/utils/testutil"
tu "github.com/tikv/pd/pkg/utils/testutil"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use the original package name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most places, it is called tu

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Merging #7408 (0afb184) into master (57fb020) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7408      +/-   ##
==========================================
- Coverage   74.28%   74.25%   -0.04%     
==========================================
  Files         451      451              
  Lines       49174    49174              
==========================================
- Hits        36527    36512      -15     
- Misses       9423     9429       +6     
- Partials     3224     3233       +9
Flag Coverage Δ
unittests 74.25% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 22, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0afb184

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0e2dad1 into tikv:master Nov 22, 2023
26 checks passed
@lhy1024 lhy1024 deleted the fix-test19 branch November 22, 2023 04:40
@rleungx rleungx mentioned this pull request Nov 30, 2023
Closed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@lhy1024 @rleungx
tests: make TestFallbackTSOConsistency stable (tikv#7408)
115d9eb 
close tikv#7407

Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestFallbackTSOConsistency is unstable
3 participants
@lhy1024 @JmPotato @rleungx