Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update tidb dashboard verstion to v2023.11.08.1 #7339

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Nov 8, 2023

What problem does this PR solve?

Issue Number: Close #7340

TiDB Dashboard release PR: pingcap/tidb-dashboard#1611

Release note

1. Show `plan_cache_hits` field for statement
2. Support tikv heap profiling

Test & Preview

tiup playground nightly --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

image

image

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 8, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from disksing and nolouch November 8, 2023 09:21
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Nov 8, 2023
Signed-off-by: baurine <2008.hbl@gmail.com>
@baurine baurine force-pushed the chore/update-dashboard-to-20231108 branch from e8dfe8a to 21b5d23 Compare November 8, 2023 09:29
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #7339 (21b5d23) into master (d189a42) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7339      +/-   ##
==========================================
- Coverage   74.49%   74.49%   -0.01%     
==========================================
  Files         446      446              
  Lines       48435    48435              
==========================================
- Hits        36083    36082       -1     
- Misses       9170     9171       +1     
  Partials     3182     3182              
Flag Coverage Δ
unittests 74.49% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@baurine
Copy link
Contributor Author

baurine commented Nov 8, 2023

This PR needs to cherry-pick to release-7.5

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2023
@Connor1996
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 21b5d23

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2023
@rleungx
Copy link
Member

rleungx commented Nov 8, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx
Copy link
Member

rleungx commented Nov 8, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 8, 2023
@nolouch
Copy link
Contributor

nolouch commented Nov 8, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 2c07c24 into tikv:master Nov 8, 2023
26 checks passed
@baurine baurine deleted the chore/update-dashboard-to-20231108 branch November 8, 2023 10:23
@baurine
Copy link
Contributor Author

baurine commented Nov 8, 2023

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@baurine: new pull request created to branch release-7.5: #7341.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 9, 2023
) (#7341)

close #7340

Signed-off-by: baurine <2008.hbl@gmail.com>

Co-authored-by: baurine <2008.hbl@gmail.com>
Co-authored-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tidb-dashboard to support tikv heap profiling
5 participants