checker: reduces the probability of deleting normal peers when the store becomes unavailable (#7249)

[lhy1024]

It is a pick for #7240, #7294 and #7315

What problem does this PR solve?

Issue Number: Close #7249

What is changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has the configuration change
• Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
• Has persistent data change

Side effects

• Possible performance regression
• Increased code complexity
• Breaking backward compatibility

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• PR to update pingcap/tiup:
• Need to cherry-pick to the release branch

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bufferflies
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7d0708f) 75.54% compared to head (7e894b4) 75.53%.

Files	Patch %	Lines
server/schedule/checker/rule_checker.go	87.09%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release-6.5    #7337      +/-   ##
===============================================
- Coverage        75.54%   75.53%   -0.02%     
===============================================
  Files              332      332              
  Lines            33700    33721      +21     
===============================================
+ Hits             25459    25471      +12     
- Misses            6047     6058      +11     
+ Partials          2194     2192       -2     

Flag	Coverage Δ
unittests	75.53% <87.09%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rleungx]

Is it duplicated?

[lhy1024]

isUnhealthyPeer contains isDownPeer and isPendingPeer

[lhy1024]

it will do in #7342

[lhy1024]

/merge

[ti-chi-bot]

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: df58b1a

[ti-chi-bot]

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.