Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: update hotfix version #7303

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

mornyx
Copy link
Contributor

@mornyx mornyx commented Nov 2, 2023

What problem does this PR solve?

Issue Number: Close #7302

What is changed and how does it work?

update dashboard version to revert pingcap/tidb-dashboard#1583 and pingcap/tidb-dashboard#1587

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: mornyx <mornyx.z@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 2, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

Hi @mornyx. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx November 2, 2023 09:05
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2023
@baurine
Copy link
Contributor

baurine commented Nov 2, 2023

TiDB Dashboard side PR: pingcap/tidb-dashboard#1609

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2023
@nolouch
Copy link
Contributor

nolouch commented Nov 2, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 04b2f6c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2023
@rleungx
Copy link
Member

rleungx commented Nov 2, 2023

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Nov 2, 2023
@rleungx
Copy link
Member

rleungx commented Nov 2, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 01fb56b into tikv:master Nov 2, 2023
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7306.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 2, 2023
close tikv#7302

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7307.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7308.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 2, 2023
close tikv#7302

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 2, 2023
close #7302

Signed-off-by: mornyx <mornyx.z@gmail.com>

Co-authored-by: mornyx <mornyx.z@gmail.com>
@baurine
Copy link
Contributor

baurine commented Nov 2, 2023

/cherry-pick release-7.1-20231102-v7.1.2

@ti-chi-bot
Copy link
Member

@baurine: new pull request created to branch release-7.1-20231102-v7.1.2: #7309.

In response to this:

/cherry-pick release-7.1-20231102-v7.1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 2, 2023
close tikv#7302

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@mornyx mornyx deleted the update-dashboard branch November 2, 2023 13:06
ti-chi-bot bot pushed a commit that referenced this pull request Nov 2, 2023
close #7302

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
@baurine
Copy link
Contributor

baurine commented Nov 6, 2023

/cherry-pick release-6.5-20231106-v6.5.5

@ti-chi-bot
Copy link
Member

@baurine: new pull request created to branch release-6.5-20231106-v6.5.5: #7323.

In response to this:

/cherry-pick release-6.5-20231106-v6.5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 6, 2023
close tikv#7302

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 7, 2023
close #7302

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login tidb-dashboard failed in 7.1.2
5 participants