pd-ctl: fix hot region show #6650

lhy1024 · 2023-06-20T14:50:36Z

What problem does this PR solve?

Issue Number: Close #6649

What is changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot · 2023-06-20T14:50:38Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-06-20T15:00:55Z

Codecov Report

Patch coverage: 93.75% and project coverage change: +0.11 🎉

Comparison is base (4d26c8b) 74.50% compared to head (531ffa0) 74.61%.

❗ Current head 531ffa0 differs from pull request most recent head 2fd34c4. Consider uploading reports for the commit 2fd34c4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6650      +/-   ##
==========================================
+ Coverage   74.50%   74.61%   +0.11%     
==========================================
  Files         417      416       -1     
  Lines       43447    43077     -370     
==========================================
- Hits        32370    32142     -228     
+ Misses       8185     8087      -98     
+ Partials     2892     2848      -44

Flag	Coverage Δ
unittests	`74.61% <93.75%> (+0.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/schedule/coordinator.go	`73.56% <93.33%> (+1.14%)`	⬆️
pkg/statistics/hot_peer_cache.go	`95.00% <100.00%> (ø)`

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

nolouch · 2023-06-25T10:05:13Z

Does it affect packHistoryHotRegions for tidb history hot region table?

lhy1024 · 2023-06-25T10:07:43Z

packHistoryHotRegions

no, it gets data from Handler.packHotRegions

nolouch · 2023-06-26T12:14:06Z

/merge

ti-chi-bot · 2023-06-26T12:14:08Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-26T12:14:09Z

This pull request has been accepted and is ready to merge.

Commit hash: 531ffa0

ti-chi-bot · 2023-06-26T12:14:23Z

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-26T12:27:13Z

In response to a cherrypick label: new pull request created to branch release-6.5: #6679.

close tikv#6649 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2023-06-26T12:27:50Z

In response to a cherrypick label: new pull request created to branch release-7.1: #6680.

HuSharp · 2023-06-27T02:00:37Z

pkg/schedule/coordinator.go

+					if region != nil {
+						h.LastUpdateTime = time.Unix(int64(region.GetInterval().GetEndTimestamp()), 0)
+					}


Why not use store heartbeat to unify?

We collect write hot info by region heartbeat

close #6649, ref #6650 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close #6649, ref #6650 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

pd-ctl: fix hot region show

531ffa0

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 20, 2023

ti-chi-bot bot requested review from HunDunDM and nolouch June 20, 2023 14:50

ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2023

CabinfeverB approved these changes Jun 21, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2023

nolouch approved these changes Jun 26, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 26, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 26, 2023

Merge branch 'master' into fix-pd-ctl

2fd34c4

ti-chi-bot bot merged commit cd5b1ce into tikv:master Jun 26, 2023

ti-chi-bot mentioned this pull request Jun 26, 2023

pd-ctl: fix hot region show (#6650) #6679

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 26, 2023

This is an automated cherry-pick of tikv#6650

a1ab4e6

close tikv#6649 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jun 26, 2023

pd-ctl: fix hot region show (#6650) #6680

Merged

HuSharp reviewed Jun 27, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pd-ctl: fix hot region show #6650

pd-ctl: fix hot region show #6650

lhy1024 commented Jun 20, 2023

ti-chi-bot bot commented Jun 20, 2023 •

edited

Loading

codecov bot commented Jun 20, 2023 •

edited

Loading

nolouch commented Jun 25, 2023

lhy1024 commented Jun 25, 2023

nolouch commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot commented Jun 26, 2023

ti-chi-bot commented Jun 26, 2023

HuSharp Jun 27, 2023

lhy1024 Jun 27, 2023

pd-ctl: fix hot region show #6650

pd-ctl: fix hot region show #6650

Conversation

lhy1024 commented Jun 20, 2023

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Jun 20, 2023 • edited Loading

codecov bot commented Jun 20, 2023 • edited Loading

Codecov Report

nolouch commented Jun 25, 2023

lhy1024 commented Jun 25, 2023

nolouch commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot commented Jun 26, 2023

ti-chi-bot commented Jun 26, 2023

HuSharp Jun 27, 2023

Choose a reason for hiding this comment

lhy1024 Jun 27, 2023

Choose a reason for hiding this comment

ti-chi-bot bot commented Jun 20, 2023 •

edited

Loading

codecov bot commented Jun 20, 2023 •

edited

Loading