-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update tidb-dashboard version to v2023.06.07.1 #6566
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @baurine. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: baurine <2008.hbl@gmail.com>
936f9b4
to
f94dcb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add a test screenshot
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #6566 +/- ##
===============================================
+ Coverage 75.58% 75.67% +0.09%
===============================================
Files 330 330
Lines 33113 33113
===============================================
+ Hits 25027 25059 +32
+ Misses 5925 5903 -22
+ Partials 2161 2151 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Do we need to update master also? |
ok, let me try it. |
This bug is only affect the 6.5.x version, so update master or not has no affect. If we do, we can do this later. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f94dcb5
|
/build |
/test build |
What problem does this PR solve?
Issue Number: Close #6564
What is changed and how does it work?
Check List
Tests
screenshot:
How to run it:
Release note