Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tidb-dashboard version to v2023.06.07.1 #6566

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Jun 7, 2023

What problem does this PR solve?

Issue Number: Close #6564

What is changed and how does it work?

Update tidb-dashboard to the lastest version (v2023.06.07.1)

Check List

Tests

  • Manual test (add detailed scripts or steps below)

screenshot:
image

How to run it:

tiup playground v6.5.3 --tiflash 0 --pd.binpath /mnt/bao/codes/work/pd/bin/pd-server

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2023

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from nolouch and Yisaer June 7, 2023 06:31
Signed-off-by: baurine <2008.hbl@gmail.com>
Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a test screenshot

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09 🎉

Comparison is base (410b176) 75.58% compared to head (f94dcb5) 75.67%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #6566      +/-   ##
===============================================
+ Coverage        75.58%   75.67%   +0.09%     
===============================================
  Files              330      330              
  Lines            33113    33113              
===============================================
+ Hits             25027    25059      +32     
+ Misses            5925     5903      -22     
+ Partials          2161     2151      -10     
Flag Coverage Δ
unittests 75.67% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HuSharp
Copy link
Member

HuSharp commented Jun 7, 2023

Do we need to update master also?

@baurine
Copy link
Contributor Author

baurine commented Jun 7, 2023

pls add a test screenshot

ok, let me try it.

@baurine
Copy link
Contributor Author

baurine commented Jun 7, 2023

Do you need to update master also?

This bug is only affect the 6.5.x version, so update master or not has no affect. If we do, we can do this later.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 7, 2023
@nolouch
Copy link
Contributor

nolouch commented Jun 7, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f94dcb5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 7, 2023
@HuSharp
Copy link
Member

HuSharp commented Jun 7, 2023

/build

@CabinfeverB
Copy link
Member

/test build

@ti-chi-bot ti-chi-bot bot merged commit 9d320ef into tikv:release-6.5 Jun 7, 2023
@baurine baurine deleted the chore/update-dashboard branch June 8, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants