Introduce keyspace safepoint interface #6419

ystaticy · 2023-05-08T11:16:50Z

What problem does this PR solve?

Issue Number: Ref #6487

What is changed and how does it work?

Add Keyspace GC Safepoint interface.

Check List

Tests

Manual test (add detailed scripts or steps below)

Code changes

Add Keyspace GC Safepoint interface.

None.

Signed-off-by: ystaticy <y_static_y@sina.com>

ti-chi-bot · 2023-05-08T11:16:53Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

disksing
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-05-08T11:17:00Z

Hi @ystaticy. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: ystaticy <y_static_y@sina.com>

ystaticy · 2023-05-18T09:34:54Z

Need pingcap/kvproto#1111 to merge first.

Signed-off-by: ystaticy <y_static_y@sina.com>

ystaticy · 2023-05-18T11:28:29Z

/cc @AmoebaProtozoa

ti-chi-bot · 2023-05-18T11:28:30Z

@ystaticy: GitHub didn't allow me to request PR reviews from the following users: AmoebaProtozoa.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @AmoebaProtozoa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: ystaticy <y_static_y@sina.com>

ystaticy · 2023-05-18T11:30:40Z

/ok-to-test

ti-chi-bot · 2023-05-18T11:30:54Z

@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rleungx · 2023-05-18T11:35:32Z

/ok-to-test

ystaticy · 2023-05-18T11:40:56Z

@AmoebaProtozoa PTAL~

ystaticy · 2023-05-18T11:42:45Z

/hold

ti-chi-bot · 2023-05-24T09:19:09Z

@zyguan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>

rleungx · 2023-05-25T04:33:52Z

tests/integrations/client/gc_client_test.go

+package client_test
+
+import (
+	"go.etcd.io/etcd/clientv3"


need to format it

rleungx

The rest LGTM

rleungx

The rest LGTM

rleungx

The rest LGTM

MyonKeminta

I'm not that familiar with PD's code. The GC related logic lgtm.

client/gc_client.go

MyonKeminta · 2023-05-22T11:04:34Z

pkg/storage/endpoint/key_path.go

@@ -260,3 +258,17 @@ func ExtractKeyspaceGroupIDFromPath(path string) (uint32, error) {
 func encodeKeyspaceGroupID(groupID uint32) string {
 	return fmt.Sprintf("%05d", groupID)
 }
+
+func buildPath(withSuffix bool, str ...string) string {


Why not continue using path.Join?

path.join will strips the / suffix which may be required in some cases

Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>

ystaticy · 2023-05-25T06:20:37Z

/hold cancel

disksing · 2023-05-25T06:28:06Z

/merge

ti-chi-bot · 2023-05-25T06:28:08Z

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-05-25T06:28:09Z

@disksing: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

disksing · 2023-05-25T06:28:34Z

/merge

ti-chi-bot · 2023-05-25T06:28:36Z

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-05-25T06:28:39Z

This pull request has been accepted and is ready to merge.

Commit hash: 7d98b8b

rleungx · 2023-05-25T06:29:19Z

/merge

ti-chi-bot · 2023-05-25T06:29:20Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

introduce keyspace safepoint interface

5eb85dc

Signed-off-by: ystaticy <y_static_y@sina.com>

ti-chi-bot bot requested review from disksing and Yisaer May 8, 2023 11:17

introduce keyspace safepoint interface

f81e14d

Signed-off-by: ystaticy <y_static_y@sina.com>

Yisaer removed their request for review May 10, 2023 06:12

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2023

ystaticy added 2 commits May 17, 2023 16:29

change resp

05a5d72

Signed-off-by: ystaticy <y_static_y@sina.com>

change resp

367cb26

Signed-off-by: ystaticy <y_static_y@sina.com>

update kvproto

5df0b4b

Signed-off-by: ystaticy <y_static_y@sina.com>

ti-chi-bot bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/needs-linked-issue labels May 18, 2023

remove unused code

73a99cb

Signed-off-by: ystaticy <y_static_y@sina.com>

ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 18, 2023

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2023

ystaticy marked this pull request as ready for review May 18, 2023 11:42

zyguan approved these changes May 24, 2023

View reviewed changes

AmoebaProtozoa added 2 commits May 24, 2023 17:53

refactor test

28175ca

Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>

Merge branch 'master' into keyspace_safepoint

316e889

rleungx reviewed May 25, 2023

View reviewed changes

tests/integrations/client/gc_client_test.go Outdated

package client_test

import (

"go.etcd.io/etcd/clientv3"

Copy link

Member

rleungx May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to format it

rleungx approved these changes May 25, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2023

rleungx approved these changes May 25, 2023

View reviewed changes

MyonKeminta reviewed May 25, 2023

View reviewed changes

AmoebaProtozoa added 2 commits May 25, 2023 13:47

sort import

3755d01

Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>

Merge branch 'master' into keyspace_safepoint

7d98b8b

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023

disksing approved these changes May 25, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2023

ti-chi-bot bot merged commit ccb0bba into tikv:master May 25, 2023

ystaticy mentioned this pull request Dec 6, 2023

GC V2 interfaces #7500

Open

6 tasks

ystaticy mentioned this pull request Mar 8, 2024

GC: Support TiDB server with different keyspace to advance GC safe point separately pingcap/tidb#51593

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce keyspace safepoint interface #6419

Introduce keyspace safepoint interface #6419

ystaticy commented May 8, 2023 •

edited

Loading

ti-chi-bot bot commented May 8, 2023 •

edited

Loading

ti-chi-bot bot commented May 8, 2023

ystaticy commented May 18, 2023

ystaticy commented May 18, 2023

ti-chi-bot bot commented May 18, 2023

ystaticy commented May 18, 2023

ti-chi-bot bot commented May 18, 2023

rleungx commented May 18, 2023

ystaticy commented May 18, 2023

ystaticy commented May 18, 2023

ti-chi-bot bot commented May 24, 2023

rleungx May 25, 2023

rleungx left a comment

rleungx left a comment

rleungx left a comment

MyonKeminta left a comment

MyonKeminta May 22, 2023

AmoebaProtozoa May 25, 2023

ystaticy commented May 25, 2023

disksing commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

disksing commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

rleungx commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

Introduce keyspace safepoint interface #6419

Introduce keyspace safepoint interface #6419

Conversation

ystaticy commented May 8, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

ti-chi-bot bot commented May 8, 2023 • edited Loading

ti-chi-bot bot commented May 8, 2023

ystaticy commented May 18, 2023

ystaticy commented May 18, 2023

ti-chi-bot bot commented May 18, 2023

ystaticy commented May 18, 2023

ti-chi-bot bot commented May 18, 2023

rleungx commented May 18, 2023

ystaticy commented May 18, 2023

ystaticy commented May 18, 2023

ti-chi-bot bot commented May 24, 2023

rleungx May 25, 2023

Choose a reason for hiding this comment

rleungx left a comment

Choose a reason for hiding this comment

rleungx left a comment

Choose a reason for hiding this comment

rleungx left a comment

Choose a reason for hiding this comment

MyonKeminta left a comment

Choose a reason for hiding this comment

MyonKeminta May 22, 2023

Choose a reason for hiding this comment

AmoebaProtozoa May 25, 2023

Choose a reason for hiding this comment

ystaticy commented May 25, 2023

disksing commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

disksing commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

rleungx commented May 25, 2023

ti-chi-bot bot commented May 25, 2023

ystaticy commented May 8, 2023 •

edited

Loading

ti-chi-bot bot commented May 8, 2023 •

edited

Loading