Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyspace, api2: fix the keyspace assignment patrol consistency #6397

Merged
merged 5 commits into from
May 5, 2023
Merged

keyspace, api2: fix the keyspace assignment patrol consistency #6397

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e8e2ac
Fix the keyspace assignment patrol consistency
JmPotato Apr 28, 2023
ab62dbd
Reduce the defer function number
JmPotato Apr 28, 2023
a2bf8a4
Fix patrolKeyspaceAssignmentState lock
JmPotato May 4, 2023
2e1f8d1
Add a TODO
JmPotato May 4, 2023
40b99b2
Merge branch 'master' into fix_keyspace_partrol
rleungx May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a TODO 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
  • Loading branch information
@JmPotato
JmPotato committed May 4, 2023
commit 2e1f8d1f9c21db7620e3f2e323871ee0405ed3d1
1 change: 1 addition & 0 deletions pkg/keyspace/keyspace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,7 @@ func (manager *Manager) allocID() (uint32, error) {

// PatrolKeyspaceAssignment is used to patrol all keyspaces and assign them to the keyspace groups.
func (manager *Manager) PatrolKeyspaceAssignment() error {
// TODO: since the number of keyspaces might be large, we should consider to assign them in batches.
return manager.store.RunInTxn(manager.ctx, func(txn kv.Txn) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only worry is that the transaction could be too large to accepted by etcd if we have too many keyspaces. Do we need to do it in batches?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me for now. We can revisit the comment above after we collect some rough data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the recent discussion, it looks like we need to process it in batch now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add txn in other operators?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

defaultKeyspaceGroup, err := manager.kgm.store.LoadKeyspaceGroup(txn, utils.DefaultKeyspaceGroupID)
if err != nil {
Expand Down