Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: fix bugs that the report interval equals the avg interval #6302

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Apr 11, 2023

What problem does this PR solve?

Issue Number: Close #6301

What is changed and how does it work?

the equal always be true if the report interval is equal the avg interval

for aot.intervalSum-aot.margin.interval >= aot.avgInterval {
aot.deltaSum -= aot.margin.delta
aot.intervalSum -= aot.margin.interval
aot.margin = aot.que.PopFront().(deltaWithInterval)
}

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None.

Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Apr 11, 2023
@bufferflies bufferflies changed the title pkg: give a initial value for interval pkg: fix bugs that the report interval equals the avg interval Apr 11, 2023
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
Copy link
Contributor Author

/check-issue-triage-complete

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.07 ⚠️

Comparison is base (dc5cfeb) 75.13% compared to head (c05bfb2) 75.06%.

❗ Current head c05bfb2 differs from pull request most recent head 68c9584. Consider uploading reports for the commit 68c9584 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6302      +/-   ##
==========================================
- Coverage   75.13%   75.06%   -0.07%     
==========================================
  Files         404      404              
  Lines       39700    39689      -11     
==========================================
- Hits        29827    29791      -36     
- Misses       7270     7289      +19     
- Partials     2603     2609       +6     
Flag Coverage Δ
unittests 75.06% <60.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/movingaverage/avg_over_time.go 94.44% <60.00%> (-1.64%) ⬇️

... and 32 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aot.GetInstantaneous() should also return rate.

pkg/movingaverage/avg_over_time.go Show resolved Hide resolved
pkg/movingaverage/avg_over_time_test.go Outdated Show resolved Hide resolved
pkg/movingaverage/avg_over_time_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2023
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2023
@nolouch
Copy link
Contributor

nolouch commented Apr 12, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ccb9fbf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2023
@ti-chi-bot
Copy link
Member

@bufferflies: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3779808 into tikv:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AvgOverTime can not work well
4 participants