Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load initial assignment and dynamically watch/apply keyspace groups' membership/distribution change #6247

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Load initial assignment and dynamically watch/apply keyspace groups' membership/distribution change #6247

merged 2 commits into from
Apr 6, 2023

Commits on Apr 6, 2023

  1. Add filter and batch handlng when loading keyspace groups meta from s… 

    …torage

Fix root path for LoadTimestamp/SaveTimestamp

Separate initial keyspace groups assignment loading from onlne dynamical change.

Implement loadKeyspaceGroup() which also returns revision.

Changed the timeout mechanism for watching the progress of loading and initialize the keyspace groups assignment

Watch keyspace group membership/distribution meta change and dynamically apply the change

Add TestLoadInitialKeyspaceGroupsAssignment and TestExtractKeyspaceGroupIDFromPath

Add test cases for loading keyspace group assignment

Add retry if there is temporary failure when loading keyspace group assignment from etcd

Removed the mutex.

The original purpose was to prevent concurrent addition/removal of keyspace groups
during critical periods such as service shutdown and online keyspace group, while the former requires
snapshot isolation to ensure all keyspace groups are properly closed and no new keyspace group is
added/initialized after that. Now we have ensured that's case by always cancelling the watch loop before closing keyspace groups in Close().

Added unitest for watching and dynamically applying keyspace group meta changes

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    de484bc View commit details
    Browse the repository at this point in the history

  2. nit 

    Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    f223e2f View commit details
    Browse the repository at this point in the history