Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: rename Operator limit #4605

Merged
merged 4 commits into from
Jan 20, 2022
Merged

metrics: rename Operator limit #4605

merged 4 commits into from
Jan 20, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jan 20, 2022

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Operator limit is difficult to understand

What is changed and how it works?

Rename it

Check List

Tests

  • No code

Release note

 None.

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 added the component/metrics Metrics. label Jan 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 20, 2022
metrics/grafana/pd.json Outdated Show resolved Hide resolved
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #4605 (e160a59) into master (f605a2c) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head e160a59 differs from pull request most recent head 45b3f37. Consider uploading reports for the commit 45b3f37 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4605      +/-   ##
==========================================
+ Coverage   74.69%   74.81%   +0.11%     
==========================================
  Files         279      277       -2     
  Lines       27627    27627              
==========================================
+ Hits        20637    20670      +33     
+ Misses       5137     5109      -28     
+ Partials     1853     1848       -5     
Flag Coverage Δ
unittests 74.81% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/api/trend.go 66.19% <0.00%> (-7.05%) ⬇️
server/region_syncer/server.go 81.45% <0.00%> (-3.98%) ⬇️
server/election/leadership.go 78.35% <0.00%> (-2.07%) ⬇️
server/member/member.go 65.24% <0.00%> (-1.61%) ⬇️
server/region_syncer/client.go 83.59% <0.00%> (-1.57%) ⬇️
server/schedule/operator/step.go 73.09% <0.00%> (-1.10%) ⬇️
pkg/btree/btree.go 87.37% <0.00%> (-0.76%) ⬇️
server/grpc_service.go 51.44% <0.00%> (-0.39%) ⬇️
server/core/basic_cluster.go 91.47% <0.00%> (-0.19%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f605a2c...45b3f37. Read the comment docs.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jan 20, 2022

/rebuild

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 20, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jan 20, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27d4554

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@ti-chi-bot ti-chi-bot merged commit c7632b8 into tikv:master Jan 20, 2022
disksing pushed a commit to oh-my-tidb/pd that referenced this pull request Feb 8, 2022
* rename, ref tikv#4399

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: 混沌DM <hundundm@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants