Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: remove useless traceRegionFlow #4604

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

HunDunDM
Copy link
Member

What problem does this PR solve?

After #3747, TraceRegionFlow has been replaced by FlowRoundByDigit and IsTraceRegionFlow() and should no longer be used.

ref #4399

What is changed and how it works?

Remove useless traceRegionFlow

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None

Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 20, 2022
@HunDunDM HunDunDM requested a review from nolouch January 20, 2022 07:08
@HunDunDM HunDunDM added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 20, 2022
@HunDunDM HunDunDM removed the request for review from nolouch January 20, 2022 07:08
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #4604 (5b2a641) into master (d1b59c1) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4604      +/-   ##
==========================================
- Coverage   74.96%   74.74%   -0.22%     
==========================================
  Files         277      277              
  Lines       27627    27626       -1     
==========================================
- Hits        20711    20650      -61     
- Misses       5082     5126      +44     
- Partials     1834     1850      +16     
Flag Coverage Δ
unittests 74.74% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 84.54% <ø> (-0.29%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/storage/endpoint/util.go 52.94% <0.00%> (-11.77%) ⬇️
server/storage/leveldb_backend.go 76.00% <0.00%> (-8.00%) ⬇️
server/tso/tso.go 61.93% <0.00%> (-7.96%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/tso/allocator_manager.go 62.74% <0.00%> (-4.64%) ⬇️
server/region_syncer/server.go 81.45% <0.00%> (-3.98%) ⬇️
server/tso/global_allocator.go 60.84% <0.00%> (-1.06%) ⬇️
pkg/btree/btree.go 87.37% <0.00%> (-0.76%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b59c1...5b2a641. Read the comment docs.

@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5b2a641

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@ti-chi-bot ti-chi-bot merged commit 4242300 into tikv:master Jan 20, 2022
@HunDunDM HunDunDM deleted the useless-traceregionflow branch January 20, 2022 07:52
disksing pushed a commit to oh-my-tidb/pd that referenced this pull request Feb 8, 2022
Signed-off-by: HunDunDM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants