test: update github action #4575

disksing · 2022-01-13T15:09:42Z

What problem does this PR solve?

CI (especially jenkin CI) runs too slow.

What is changed and how it works?

All-in GitHub Actions
Split unit tests by weight
Run unit test and coverage in parallel

After merging this PR, we can discard unit test in Jenkins

Check List

Tests

Unit test

Release note

None

ti-chi-bot · 2022-01-13T15:09:43Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-01-14T02:06:17Z

Codecov Report

Merging #4575 (770c292) into master (2aaca94) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4575      +/-   ##
==========================================
+ Coverage   74.68%   74.89%   +0.21%     
==========================================
  Files         276      276              
  Lines       27928    27611     -317     
==========================================
- Hits        20857    20680     -177     
+ Misses       5196     5064     -132     
+ Partials     1875     1867       -8

Flag	Coverage Δ
unittests	`74.89% <ø> (+0.21%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/storage/endpoint/rule.go	`83.33% <0.00%> (-11.12%)`	⬇️
server/schedule/placement/region_rule_cache.go	`83.82% <0.00%> (-4.28%)`	⬇️
server/cluster/store_limiter.go	`47.50% <0.00%> (-3.57%)`	⬇️
server/schedule/labeler/labeler.go	`79.45% <0.00%> (-2.74%)`	⬇️
server/election/leadership.go	`73.19% <0.00%> (-2.07%)`	⬇️
server/schedule/operator/status_tracker.go	`94.00% <0.00%> (-0.24%)`	⬇️
pkg/cache/fifo.go	`100.00% <0.00%> (ø)`
pkg/tempurl/tempurl.go	`60.00% <0.00%> (ø)`
pkg/movingaverage/queue.go	`100.00% <0.00%> (ø)`
server/storage/kv/mem_kv.go	`100.00% <0.00%> (ø)`
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aaca94...770c292. Read the comment docs.

ref tikv#4399 Signed-off-by: disksing <i@disksing.com>

Signed-off-by: disksing <i@disksing.com>

scripts/ci-subtask.sh

Co-authored-by: JmPotato <ghzpotato@gmail.com> Signed-off-by: disksing <i@disksing.com>

Signed-off-by: disksing <i@disksing.com>

.github/workflows/pd-tests.yaml

Signed-off-by: disksing <i@disksing.com>

lhy1024 · 2022-01-14T09:40:01Z

server/schedule/region_scatterer_test.go

-func (s *testScatterRegionSuite) TestFiveSpecialStores(c *C) {
-	s.scatterSpecial(c, 5, 5, 100)
-	s.scatterSpecial(c, 5, 5, 1000)
+func (s *testScatterRegionSuite) TestScatterRegions(c *C) {


why to reduce them

it runs too slow when -race is enabled.

JmPotato · 2022-01-17T03:28:27Z

/merge

ti-chi-bot · 2022-01-17T03:28:28Z

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

disksing · 2022-01-17T03:28:29Z

/merge

ti-chi-bot · 2022-01-17T03:28:29Z

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-01-17T03:28:30Z

This pull request has been accepted and is ready to merge.

Commit hash: 26ca4d4

ti-chi-bot · 2022-01-17T03:28:30Z

This pull request has been accepted and is ready to merge.

Commit hash: 26ca4d4

ti-chi-bot · 2022-01-17T03:28:43Z

@disksing: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

* build: update GitHub Actions ref tikv#4399 Signed-off-by: disksing <i@disksing.com> * tidy Signed-off-by: disksing <i@disksing.com> * move docker out of check Signed-off-by: disksing <i@disksing.com> * Update scripts/ci-subtask.sh Co-authored-by: JmPotato <ghzpotato@gmail.com> Signed-off-by: disksing <i@disksing.com> * clean up Signed-off-by: disksing <i@disksing.com> * 6 workers for pd-tests Signed-off-by: disksing <i@disksing.com> * merge together Signed-off-by: disksing <i@disksing.com> * minor update Signed-off-by: disksing <i@disksing.com> * simplify test Signed-off-by: disksing <i@disksing.com> Co-authored-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 13, 2022

ti-chi-bot requested review from JmPotato and rleungx January 13, 2022 15:09

build: update GitHub Actions

9205dd3

ref tikv#4399 Signed-off-by: disksing <i@disksing.com>

disksing force-pushed the makefile3 branch from 20ecced to 9205dd3 Compare January 14, 2022 05:39

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 14, 2022

disksing marked this pull request as ready for review January 14, 2022 05:44

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2022

disksing added 2 commits January 14, 2022 13:59

tidy

2797e0d

Signed-off-by: disksing <i@disksing.com>

move docker out of check

c4917c7

Signed-off-by: disksing <i@disksing.com>

JmPotato reviewed Jan 14, 2022

View reviewed changes

scripts/ci-subtask.sh Outdated Show resolved Hide resolved

Update scripts/ci-subtask.sh

c4690b5

Co-authored-by: JmPotato <ghzpotato@gmail.com> Signed-off-by: disksing <i@disksing.com>

disksing force-pushed the makefile3 branch from cd81a97 to c4690b5 Compare January 14, 2022 06:20

clean up

8ea038d

Signed-off-by: disksing <i@disksing.com>

disksing requested a review from JmPotato January 14, 2022 06:31

bufferflies reviewed Jan 14, 2022

View reviewed changes

.github/workflows/pd-tests.yaml Outdated Show resolved Hide resolved

6 workers for pd-tests

8522ebc

Signed-off-by: disksing <i@disksing.com>

disksing requested a review from bufferflies January 14, 2022 07:18

disksing added 4 commits January 14, 2022 15:56

merge together

e96da45

Signed-off-by: disksing <i@disksing.com>

minor update

c4022c5

Signed-off-by: disksing <i@disksing.com>

simplify test

306e2c2

Signed-off-by: disksing <i@disksing.com>

Merge branch 'master' into makefile3

9eca221

lhy1024 reviewed Jan 14, 2022

View reviewed changes

disksing requested a review from lhy1024 January 14, 2022 09:43

Merge branch 'master' into makefile3

26ca4d4

JmPotato approved these changes Jan 17, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2022

rleungx approved these changes Jan 17, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2022

Merge branch 'master' into makefile3

770c292

ti-chi-bot merged commit cd51927 into tikv:master Jan 17, 2022

disksing deleted the makefile3 branch January 17, 2022 03:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: update github action #4575

test: update github action #4575

disksing commented Jan 13, 2022 •

edited

Loading

ti-chi-bot commented Jan 13, 2022 •

edited

Loading

codecov bot commented Jan 14, 2022 •

edited

Loading

lhy1024 Jan 14, 2022

disksing Jan 14, 2022

JmPotato commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

disksing commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

test: update github action #4575

test: update github action #4575

Conversation

disksing commented Jan 13, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jan 13, 2022 • edited Loading

codecov bot commented Jan 14, 2022 • edited Loading

Codecov Report

lhy1024 Jan 14, 2022

Choose a reason for hiding this comment

disksing Jan 14, 2022

Choose a reason for hiding this comment

JmPotato commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

disksing commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

ti-chi-bot commented Jan 17, 2022

disksing commented Jan 13, 2022 •

edited

Loading

ti-chi-bot commented Jan 13, 2022 •

edited

Loading

codecov bot commented Jan 14, 2022 •

edited

Loading