Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: reorg Makefile #4574

Merged
merged 6 commits into from
Jan 14, 2022
Merged

build: reorg Makefile #4574

merged 6 commits into from
Jan 14, 2022

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Makefile is not well organized and there many stale targets.

What is changed and how it works?

  • remove some targets
  • reorder some targets
  • merge some targets
  • rewrite some targets
  • remove go version check and GO111MODULE setting

Check List

Tests

  • Unit test

Release note

None

ref tikv#4399

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 13, 2022
@disksing
Copy link
Contributor Author

/run-test

@disksing
Copy link
Contributor Author

/build

Signed-off-by: disksing <i@disksing.com>
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #4574 (f5e138d) into master (3792f07) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4574      +/-   ##
==========================================
+ Coverage   74.93%   75.00%   +0.07%     
==========================================
  Files         265      265              
  Lines       27904    27904              
==========================================
+ Hits        20909    20930      +21     
+ Misses       5137     5116      -21     
  Partials     1858     1858              
Flag Coverage Δ
unittests 75.00% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/region_syncer/client.go 79.68% <0.00%> (-3.91%) ⬇️
server/schedule/labeler/labeler.go 79.45% <0.00%> (-2.74%) ⬇️
pkg/dashboard/adapter/manager.go 82.97% <0.00%> (-2.13%) ⬇️
server/core/storage.go 69.31% <0.00%> (-1.52%) ⬇️
server/schedule/operator/step.go 73.09% <0.00%> (-1.10%) ⬇️
server/cluster/cluster.go 82.87% <0.00%> (-1.05%) ⬇️
tools/pd-ctl/pdctl/command/hot_command.go 71.03% <0.00%> (-0.69%) ⬇️
client/client.go 72.83% <0.00%> (+0.10%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3792f07...f5e138d. Read the comment docs.

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 14, 2022
Makefile Show resolved Hide resolved
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 14, 2022
@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f5e138d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 14, 2022
@ti-chi-bot ti-chi-bot merged commit 32832a3 into tikv:master Jan 14, 2022
@disksing disksing deleted the makefile2 branch January 14, 2022 06:37
disksing added a commit to oh-my-tidb/pd that referenced this pull request Feb 8, 2022
* build: reorg Makefile

ref tikv#4399

Signed-off-by: disksing <i@disksing.com>

* minor update

Signed-off-by: disksing <i@disksing.com>

* minor fix

Signed-off-by: disksing <i@disksing.com>

* add back daily coverage

Signed-off-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants