Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use SerialSuites to reduce the servers in tests at the same time #4171

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

HunDunDM
Copy link
Member

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

close #4165

The watcher has been blocked. After troubleshooting its own problem, it is suspected that too many etcd have been started at the same time, causing the FD to run out.

What is changed and how it works?

*: use SerialSuites to reduce the servers in tests at the same time

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 27, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 27, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #4171 (1e40730) into master (7c76c98) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
+ Coverage   74.73%   74.76%   +0.02%     
==========================================
  Files         260      260              
  Lines       26481    26481              
==========================================
+ Hits        19791    19798       +7     
+ Misses       4917     4908       -9     
- Partials     1773     1775       +2     
Flag Coverage Δ
unittests 74.76% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/etcdutil/etcdutil.go 82.35% <0.00%> (-5.89%) ⬇️
server/member/member.go 63.10% <0.00%> (-3.75%) ⬇️
server/tso/tso.go 64.20% <0.00%> (-2.85%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
server/schedule/operator/step.go 72.42% <0.00%> (-1.11%) ⬇️
server/grpc_service.go 46.93% <0.00%> (-0.23%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (ø)
client/base_client.go 84.23% <0.00%> (+0.54%) ⬆️
server/server.go 72.15% <0.00%> (+0.74%) ⬆️
server/tso/allocator_manager.go 66.50% <0.00%> (+0.83%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c76c98...1e40730. Read the comment docs.

@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1e40730

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2021
@ti-chi-bot ti-chi-bot merged commit 12d9da6 into tikv:master Sep 27, 2021
@HunDunDM HunDunDM deleted the reduce-test-etcd branch September 27, 2021 10:37
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Sep 28, 2021
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Sep 28, 2021
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Sep 28, 2021
@HunDunDM
Copy link
Member Author

HunDunDM commented Oct 8, 2021

Since the concurrency of the Suite is also 1 during the test, maybe the PR has no effect.

ti-chi-bot added a commit that referenced this pull request Oct 13, 2021
* remove watcherEnabled

Signed-off-by: HunDunDM <hundundm@gmail.com>

* encryption: refine key manager watcher loop

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix log

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* address comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* *: use SerialSuites to reduce the servers in tests at the same time (#4171)

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
hzh0425 pushed a commit to hzh0425/pd that referenced this pull request Nov 16, 2021
…ikv#4171)

Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: hzh0425 <642256541@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci failed runing too long TestWatcher
3 participants