Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: not limit remove peer of the down store (#4097) #4115

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4097

What problem does this PR solve?

Close #4090.

What is changed and how it works?

This PR adds a flag in the remove peer step to let the store limit not work when the remove store is down.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need resolve conflict

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 14, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 14, 2021

cc @rleungx

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the cherry-pick-4097-to-release-5.1 branch from 0b184ca to 2b91dee Compare September 15, 2021 09:12
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 15, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c785920

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #4115 (1207678) into release-5.1 (48b3ffd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-5.1    #4115   +/-   ##
============================================
  Coverage        75.20%   75.20%           
============================================
  Files              245      245           
  Lines            24673    24682    +9     
============================================
+ Hits             18556    18563    +7     
- Misses            4496     4499    +3     
+ Partials          1621     1620    -1     
Flag Coverage Δ
unittests 75.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/checker_controller.go 68.29% <100.00%> (+0.79%) ⬆️
server/schedule/operator/builder.go 88.10% <100.00%> (+0.12%) ⬆️
server/schedule/operator/step.go 67.76% <100.00%> (-1.34%) ⬇️
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
server/election/lease.go 89.83% <0.00%> (-6.78%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/cluster/coordinator.go 73.31% <0.00%> (-0.73%) ⬇️
server/cluster/cluster.go 82.02% <0.00%> (-0.38%) ⬇️
server/tso/allocator_manager.go 78.79% <0.00%> (-0.17%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b3ffd...1207678. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit b6d8d5a into tikv:release-5.1 Sep 15, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.1.2 milestone Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/schedule Scheduling logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants