Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

placement: do not delete orphan peers if some peers selected by RuleFit is down or pending (#4067) #4087

Closed
wants to merge 1 commit into from
Closed

placement: do not delete orphan peers if some peers selected by RuleFit is down or pending (#4067) #4087

wants to merge 1 commit into from

Conversation

andylokandy
Copy link
Contributor

What problem does this PR solve?

fixes #4045

Related changes

  • Need to cherry-pick to the release-5.0

Release note

None

@andylokandy @nolouch
placement: do not delete orphan peers if some peers selected by RuleF…
f3cfb73 
…it is down or pending (tikv#4067)

* address comment

Signed-off-by: Andy Lok <andylokandy@hotmail.com>

* add test

Signed-off-by: Andy Lok <andylokandy@hotmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@andylokandy: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Sep 6, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2021
@andylokandy
Copy link
Contributor Author

@nolouch PTAL

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 13, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 27, 2021

Do we need to merge it?

@andylokandy
Copy link
Contributor Author

@nolouch not yet. We may stay in this state until 15th October.

@HunDunDM HunDunDM removed their request for review November 18, 2021 04:20
@rleungx
Copy link
Member

rleungx commented Dec 1, 2021

@andylokandy Can we merge it now?

@andylokandy
Copy link
Contributor Author

andylokandy commented Dec 1, 2021 •
edited
Loading

@andylokandy Can we merge it now?

No. Instead please remove this hotfix branch, thanks.

Edit: Seems that we have to keep this branch as it is forever...

@andylokandy andylokandy closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@disksing disksing disksing approved these changes

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andylokandy @ti-chi-bot @nolouch @rleungx @disksing