placement: do not delete orphan peers if some peers selected by RuleFit is down or pending (#4067)

[ti-chi-bot]

This is an automated cherry-pick of #4067

What problem does this PR solve?

fixes #4045

Related changes

• Need to cherry-pick to the release-5.0

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• HunDunDM
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[andylokandy]

@nolouch I've no permission to resolve the conflict 😥

[ti-chi-bot]

@andylokandy: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[codecov]

Codecov Report

Merging #4075 (7ae20b9) into release-5.2 (dde3a12) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-5.2    #4075      +/-   ##
===============================================
+ Coverage        74.63%   74.79%   +0.15%     
===============================================
  Files              249      249              
  Lines            25628    25634       +6     
===============================================
+ Hits             19128    19172      +44     
+ Misses            4809     4780      -29     
+ Partials          1691     1682       -9     

Flag	Coverage Δ
unittests	74.79% <100.00%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedule/checker/rule_checker.go	82.79% <100.00%> (+1.68%)	⬆️
pkg/dashboard/adapter/manager.go	78.72% <0.00%> (-4.26%)	⬇️
server/schedulers/random_merge.go	60.00% <0.00%> (-3.34%)	⬇️
server/tso/tso.go	59.11% <0.00%> (-1.11%)	⬇️
pkg/btree/btree.go	85.78% <0.00%> (-0.97%)	⬇️
client/client.go	71.82% <0.00%> (-0.14%)	⬇️
server/grpc_service.go	47.23% <0.00%> (+0.33%)	⬆️
server/cluster/cluster.go	82.69% <0.00%> (+0.35%)	⬆️
server/member/member.go	65.24% <0.00%> (+0.53%)	⬆️
server/schedule/operator_controller.go	84.35% <0.00%> (+0.79%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde3a12...7ae20b9. Read the comment docs.

[HunDunDM]

/merge

[ti-chi-bot]

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 7ae20b9