Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: close ticker when function returns #4053

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 30, 2021

What problem does this PR solve?

There are some tickers that are not closed.

What is changed and how it works?

Just as the title says.

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the component/misc Some other things. label Aug 30, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #4053 (bbee579) into master (c43115e) will increase coverage by 0.05%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4053      +/-   ##
==========================================
+ Coverage   74.53%   74.59%   +0.05%     
==========================================
  Files         258      258              
  Lines       26075    26079       +4     
==========================================
+ Hits        19436    19453      +17     
+ Misses       4901     4893       -8     
+ Partials     1738     1733       -5     
Flag Coverage Δ
unittests 74.59% <89.47%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/region_storage.go 75.58% <85.71%> (-0.29%) ⬇️
server/config/config.go 75.05% <100.00%> (+0.20%) ⬆️
server/region_syncer/server.go 83.21% <100.00%> (+0.12%) ⬆️
server/member/member.go 63.10% <0.00%> (-3.21%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-3.20%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 65.99% <0.00%> (-1.22%) ⬇️
server/tso/allocator_manager.go 67.27% <0.00%> (-0.51%) ⬇️
server/handler.go 42.89% <0.00%> (-0.50%) ⬇️
server/grpc_service.go 47.05% <0.00%> (-0.46%) ⬇️
server/schedule/operator_controller.go 85.54% <0.00%> (+0.79%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2591987...bbee579. Read the comment docs.

@rleungx rleungx requested review from nolouch and removed request for JmPotato August 31, 2021 03:39
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2021
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 3, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 3, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f44d31d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 3, 2021
@ti-chi-bot ti-chi-bot merged commit fa09aff into tikv:master Sep 3, 2021
v01dstar pushed a commit to v01dstar/pd that referenced this pull request Oct 28, 2021
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/misc Some other things. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants