scheduler: fix inaccurate statistics and config #3949

HunDunDM · 2021-08-04T05:24:05Z

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

What is changed and how it works?

scheduler: fix inaccurate statistics and config

Check List

Tests

Unit test

Code changes

Side effects

Related changes

Need to cherry-pick to the release branch

Release note

None

Signed-off-by: HunDunDM <hundundm@gmail.com>

ti-chi-bot · 2021-08-04T05:24:06Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2021-08-04T05:37:56Z

Codecov Report

Merging #3949 (97256cd) into master (e23a9e5) will decrease coverage by 0.10%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##           master    #3949      +/-   ##
==========================================
- Coverage   74.70%   74.59%   -0.11%     
==========================================
  Files         246      246              
  Lines       25073    25094      +21     
==========================================
- Hits        18731    18720      -11     
- Misses       4691     4714      +23     
- Partials     1651     1660       +9

Flag	Coverage Δ
unittests	`74.59% <97.29%> (-0.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedulers/hot_region.go	`86.41% <96.42%> (-0.52%)`	⬇️
server/schedulers/hot_region_config.go	`84.40% <100.00%> (+0.44%)`	⬆️
server/schedulers/utils.go	`92.89% <100.00%> (+0.03%)`	⬆️
server/schedulers/shuffle_hot_region.go	`55.10% <0.00%> (-10.21%)`	⬇️
server/region_syncer/server.go	`83.08% <0.00%> (-5.89%)`	⬇️
server/schedulers/random_merge.go	`60.00% <0.00%> (-3.34%)`	⬇️
server/tso/tso.go	`60.22% <0.00%> (-2.77%)`	⬇️
server/schedule/operator/step.go	`68.10% <0.00%> (-1.67%)`	⬇️
pkg/btree/btree.go	`85.30% <0.00%> (-0.97%)`	⬇️
server/cluster/coordinator.go	`73.42% <0.00%> (-0.70%)`	⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23a9e5...97256cd. Read the comment docs.

nolouch

lgtm

server/schedulers/hot_region.go

server/schedulers/utils.go

Signed-off-by: HunDunDM <hundundm@gmail.com>

HunDunDM · 2021-08-04T07:55:34Z

/merge

ti-chi-bot · 2021-08-04T07:55:34Z

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-08-04T07:55:36Z

This pull request has been accepted and is ready to merge.

Commit hash: 932a814

Signed-off-by: HunDunDM <hundundm@gmail.com>

ti-chi-bot · 2021-08-11T13:36:57Z

In response to a cherrypick label: new pull request created: #3964.

ti-chi-bot · 2021-08-11T13:36:57Z

In response to a cherrypick label: new pull request created: #3965.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2021-08-11T13:36:58Z

In response to a cherrypick label: new pull request created: #3966.

Signed-off-by: HunDunDM <hundundm@gmail.com>

* scheduler: simplify pending influence (#3658) Signed-off-by: HunDunDM <hundundm@gmail.com> * schedulers: unify the use and GC of hot-region's pendings and regionPendings (#3921) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: remove the useless code in hot-region-scheduler (#3833) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: fix inaccurate statistics and config (#3949) Signed-off-by: HunDunDM <hundundm@gmail.com> * tiny fix Signed-off-by: HunDunDM <hundundm@gmail.com> * tiny fix Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

Signed-off-by: HunDunDM <hundundm@gmail.com>

* scheduler: simplify pending influence (#3658) Signed-off-by: HunDunDM <hundundm@gmail.com> * schedulers: unify the use and GC of hot-region's pendings and regionPendings (#3921) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: remove the useless code in hot-region-scheduler (#3833) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: fix inaccurate statistics and config (#3949) Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

Signed-off-by: HunDunDM <hundundm@gmail.com>

* scheduler: remove the useless code in hot-region-scheduler (#3833) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: fix inaccurate statistics and config (#3949) Signed-off-by: HunDunDM <hundundm@gmail.com> * tiny fix Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

scheduler: fix inaccurate statistics and config

d9903cf

Signed-off-by: HunDunDM <hundundm@gmail.com>

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 4, 2021

ti-chi-bot requested a review from nolouch August 4, 2021 05:24

nolouch requested a review from lhy1024 August 4, 2021 05:36

nolouch requested changes Aug 4, 2021

View reviewed changes

nolouch approved these changes Aug 4, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021

HunDunDM added the priority/P1 The issue has P1 priority. label Aug 4, 2021

lhy1024 reviewed Aug 4, 2021

View reviewed changes

server/schedulers/hot_region.go Show resolved Hide resolved

server/schedulers/utils.go Outdated Show resolved Hide resolved

lhy1024 mentioned this pull request Aug 4, 2021

Adjustable Priority Multidimensional Hot Scheduler Tasklist #3869

Closed

28 tasks

address comment

932a814

Signed-off-by: HunDunDM <hundundm@gmail.com>

lhy1024 approved these changes Aug 4, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021

Merge branch 'master' into write-leader-pending

97256cd

ti-chi-bot merged commit 22f23fe into tikv:master Aug 4, 2021

HunDunDM deleted the write-leader-pending branch August 4, 2021 08:11

HunDunDM added a commit that referenced this pull request Aug 4, 2021

scheduler: fix inaccurate statistics and config (#3949)

e0df447

Signed-off-by: HunDunDM <hundundm@gmail.com>

HunDunDM added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 labels Aug 11, 2021

ti-chi-bot mentioned this pull request Aug 11, 2021

scheduler: fix inaccurate statistics and config (#3949) #3964

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 11, 2021

This is an automated cherry-pick of tikv#3949

2a9b3a8

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 11, 2021

This is an automated cherry-pick of tikv#3949

5272137

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 11, 2021

This is an automated cherry-pick of tikv#3949

4e9019b

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

This was referenced Aug 11, 2021

scheduler: fix inaccurate statistics and config (#3949) #3965

Merged

scheduler: fix inaccurate statistics and config (#3949) #3966

Merged

HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Sep 1, 2021

scheduler: fix inaccurate statistics and config (tikv#3949)

52724bf

Signed-off-by: HunDunDM <hundundm@gmail.com>

HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Sep 8, 2021

scheduler: fix inaccurate statistics and config (tikv#3949)

f2ea3be

Signed-off-by: HunDunDM <hundundm@gmail.com>

HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Sep 15, 2021

scheduler: fix inaccurate statistics and config (tikv#3949)

a41a2d1

Signed-off-by: HunDunDM <hundundm@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scheduler: fix inaccurate statistics and config #3949

scheduler: fix inaccurate statistics and config #3949

HunDunDM commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021 •

edited

Loading

codecov bot commented Aug 4, 2021 •

edited

Loading

nolouch left a comment

HunDunDM commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

ti-chi-bot commented Aug 11, 2021

ti-chi-bot commented Aug 11, 2021

ti-chi-bot commented Aug 11, 2021

scheduler: fix inaccurate statistics and config #3949

scheduler: fix inaccurate statistics and config #3949

Conversation

HunDunDM commented Aug 4, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Aug 4, 2021 • edited Loading

codecov bot commented Aug 4, 2021 • edited Loading

Codecov Report

nolouch left a comment

Choose a reason for hiding this comment

HunDunDM commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

ti-chi-bot commented Aug 11, 2021

ti-chi-bot commented Aug 11, 2021

ti-chi-bot commented Aug 11, 2021

ti-chi-bot commented Aug 4, 2021 •

edited

Loading

codecov bot commented Aug 4, 2021 •

edited

Loading