Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make github action effective for release-5.1 #3757

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Jun 9, 2021

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

What is changed and how it works?

ci: make github action effective for release-5.1

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 9, 2021
@ti-chi-bot ti-chi-bot requested a review from JmPotato June 9, 2021 09:51
@HunDunDM HunDunDM added component/build Build process. require-LGT1 Indicates that the PR requires an LGTM. labels Jun 9, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 9, 2021
@HunDunDM
Copy link
Member Author

HunDunDM commented Jun 9, 2021

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ba1d14e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #3757 (ba1d14e) into master (39c4462) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3757      +/-   ##
==========================================
+ Coverage   75.11%   75.14%   +0.03%     
==========================================
  Files         245      245              
  Lines       24544    24544              
==========================================
+ Hits        18436    18444       +8     
+ Misses       4490     4486       -4     
+ Partials     1618     1614       -4     
Flag Coverage Δ
unittests 75.14% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-8.52%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/tso/global_allocator.go 70.55% <0.00%> (-2.78%) ⬇️
server/tso/tso.go 71.91% <0.00%> (-1.13%) ⬇️
server/server.go 72.23% <0.00%> (-0.61%) ⬇️
server/cluster/cluster.go 82.92% <0.00%> (-0.36%) ⬇️
server/grpc_service.go 48.57% <0.00%> (+0.22%) ⬆️
server/tso/allocator_manager.go 79.96% <0.00%> (+0.33%) ⬆️
server/schedule/operator/builder.go 88.39% <0.00%> (+0.40%) ⬆️
server/cluster/coordinator.go 73.14% <0.00%> (+0.71%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed34c0b...ba1d14e. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 3ba158c into tikv:master Jun 9, 2021
@HunDunDM HunDunDM deleted the release-5.1-action branch June 9, 2021 10:12
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Jun 9, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Jun 11, 2021
* ci: make github action effective for release-5.1

Signed-off-by: HunDunDM <hundundm@gmail.com>

* address comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* address comment

Signed-off-by: HunDunDM <hundundm@gmail.com>

* ci: make github action effective for release-5.1 (#3757)

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Build process. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants