Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: refine pd-heartbeat-bench #3688

Merged
merged 8 commits into from
Aug 1, 2022
Merged

tools: refine pd-heartbeat-bench #3688

merged 8 commits into from
Aug 1, 2022

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented May 18, 2021 •
edited by nolouch
Loading

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

Issue Number: Close #4399

What is changed and how it works?

  • refine pd-heartbeat-bench to bench more complicated situations

Check List

Tests

  • No code
    • Only the code of the bench tool has been modified

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021 •
edited
Loading

Codecov Report

Merging #3688 (7acfc22) into master (e1c6ad3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3688   +/-   ##
=======================================
  Coverage   75.63%   75.64%           
=======================================
  Files         312      312           
  Lines       31054    31054           
=======================================
+ Hits        23489    23492    +3     
+ Misses       5561     5554    -7     
- Partials     2004     2008    +4
Flag Coverage Δ
unittests 75.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/id/id.go 80.76% <0.00%> (-3.85%) ⬇️
server/tso/tso.go 67.79% <0.00%> (-2.26%) ⬇️
server/region_syncer/client.go 85.82% <0.00%> (-2.24%) ⬇️
server/server.go 74.83% <0.00%> (-1.06%) ⬇️
server/cluster/cluster.go 83.61% <0.00%> (-0.91%) ⬇️
client/client.go 69.52% <0.00%> (-0.11%) ⬇️
server/cluster/unsafe_recovery_controller.go 80.18% <0.00%> (ø)
server/grpc_service.go 49.40% <0.00%> (+0.08%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c6ad3...7acfc22. Read the comment docs.

@HunDunDM
tools: refine pd-heartbeat-bench
ebb4e9b 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 20, 2021
@HunDunDM HunDunDM marked this pull request as ready for review May 20, 2021 04:48
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2021
JmPotato
JmPotato reviewed May 20, 2021
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

tools/pd-heartbeat-bench/main.go Outdated
}
// All stores finished heartbeat once.
for storeID := 1; storeID <= *storeCount; storeID++ {
<-groupEndNotify[storeID]
}

close(report.Results())
endTime := time.Now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use time.Since which is more clear.

@HunDunDM
address comment
e76f13b 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM
change default value
da66cb3 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM
fix typo
6f74a6b 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 20, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@HunDunDM HunDunDM added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2021
nolouch
nolouch reviewed May 28, 2021
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nolouch
nolouch reviewed Jun 16, 2021
View reviewed changes
tools/pd-heartbeat-bench/main.go
// update flow
for _, i := range rs.updateFlow {
region := rs.regions[i]
region.BytesWritten += bytesUnit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need a param to control the flow change range.

@disksing disksing removed their request for review June 29, 2021 03:17
@lhy1024 lhy1024 removed their request for review November 16, 2021 09:04
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 16, 2021
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Dec 16, 2021
@nolouch
Copy link
Contributor

nolouch commented Dec 16, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6f74a6b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2021
@nolouch
Copy link
Contributor

nolouch commented May 30, 2022

Can we merge it?

@disksing disksing requested a review from JmPotato July 25, 2022 04:35
@nolouch nolouch removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/invalid-commit-message labels Aug 1, 2022
@nolouch
Copy link
Contributor

nolouch commented Aug 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Contributor

nolouch commented Aug 1, 2022

/rebuild

@ti-chi-bot ti-chi-bot merged commit ed6e4b8 into tikv:master Aug 1, 2022
@HunDunDM HunDunDM deleted the heartbeat-bench branch September 2, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta issue
5 participants
@HunDunDM @ti-chi-bot @nolouch @JmPotato @disksing