Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: update auto-assign config #3683

Merged
merged 1 commit into from
May 17, 2021

Conversation

HunDunDM
Copy link
Member

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

What is changed and how it works?

Synchronize the list of auto-assign with include_reviewers in ti-community-blunderbuss.
Related ti-community-infra/configs#313

Check List

Tests

  • No code

Release note

None

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM added the component/misc Some other things. label May 17, 2021
@HunDunDM HunDunDM requested a review from Yisaer May 17, 2021 08:49
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 17, 2021
@HunDunDM HunDunDM added the require-LGT1 Indicates that the PR requires an LGTM. label May 17, 2021
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2021
@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0254e88

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #3683 (0254e88) into master (c84bb95) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
- Coverage   74.80%   74.76%   -0.04%     
==========================================
  Files         244      244              
  Lines       24307    24307              
==========================================
- Hits        18182    18173       -9     
- Misses       4514     4515       +1     
- Partials     1611     1619       +8     
Flag Coverage Δ
unittests 74.76% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-3.20%) ⬇️
server/tso/allocator_manager.go 77.12% <0.00%> (-3.18%) ⬇️
server/member/member.go 68.81% <0.00%> (-2.69%) ⬇️
server/config/persist_options.go 91.37% <0.00%> (-0.79%) ⬇️
server/core/storage.go 67.68% <0.00%> (-0.77%) ⬇️
server/schedule/operator/step.go 68.43% <0.00%> (-0.67%) ⬇️
server/cluster/cluster.go 81.86% <0.00%> (-0.48%) ⬇️
server/schedule/operator_controller.go 85.19% <0.00%> (-0.41%) ⬇️
server/server.go 71.58% <0.00%> (-0.16%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84bb95...0254e88. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 7e6d4a0 into tikv:master May 17, 2021
@HunDunDM HunDunDM deleted the auto-assign-config branch May 17, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/misc Some other things. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants