schedule: add enable-joint-consensus config #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
lhy1024
reviewed
Sep 14, 2020
| @@ -755,6 +758,7 @@ const ( | |||
| defaultSchedulerMaxWaitingOperator = 5 | |||
| defaultLeaderSchedulePolicy = "count" | |||
| defaultStoreLimitMode = "manual" | |||
| defaultEnableJointConsensus = true | |||
There was a problem hiding this comment.
will we start it by default?
There was a problem hiding this comment.
Yes, it improves stability. And this is on the master branch. If there are some bugs with this feature, we can turn it off on the release branch.
| func (o *PersistOptions) IsDebugMetricsEnabled() bool { | ||
| return o.GetScheduleConfig().EnableDebugMetrics | ||
| } | ||
|
|
||
| // IsUseJointConsensus returns if using joint consensus as a operator step is enabled. | ||
| func (o *PersistOptions) IsUseJointConsensus() bool { |
There was a problem hiding this comment.
just like IsUseRegionStorage
lhy1024
approved these changes
Sep 15, 2020
ti-srebot
approved these changes
Sep 15, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@HunDunDM merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@HunDunDM merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zheng Xiangsheng hundundm@gmail.com
What problem does this PR solve?
For details, please refer to #2860
What is changed and how it works?
enable-joint-consensusconfigCheck List
Code changes
Release note
enable-joint-consensusconfig