Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refine the fatal log (#2896) #2907

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2896 to release-4.0


What problem does this PR solve?

Part of #2704.

What is changed and how it works?

This PR refines all the fatal level log according to the RFC

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

@ti-srebot ti-srebot added component/log Log. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Sep 7, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 7, 2020
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix conflict

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2907 into release-4.0 will decrease coverage by 0.31%.
The diff coverage is 15.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2907      +/-   ##
===============================================
- Coverage        77.75%   77.43%   -0.32%     
===============================================
  Files              210      210              
  Lines            22811    22813       +2     
===============================================
- Hits             17737    17666      -71     
- Misses            3731     3818      +87     
+ Partials          1343     1329      -14     
Impacted Files Coverage Δ
server/config/config.go 77.65% <0.00%> (ø)
server/core/store.go 80.12% <0.00%> (ø)
server/join/join.go 62.92% <0.00%> (ø)
server/kv/levedb_kv.go 82.85% <0.00%> (ø)
server/member/leader.go 75.76% <0.00%> (+1.92%) ⬆️
server/region_syncer/history_buffer.go 83.33% <0.00%> (ø)
server/schedule/scheduler.go 65.30% <0.00%> (ø)
server/util.go 46.91% <0.00%> (ø)
server/cluster/version.go 75.00% <20.00%> (-6.82%) ⬇️
pkg/logutil/log.go 85.27% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20dad94...9e3988c. Read the comment docs.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/run-all-tests

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 7, 2020
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 7, 2020
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants