Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: refine IsFeatureSupported #2889

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Sep 3, 2020

Signed-off-by: Zheng Xiangsheng hundundm@gmail.com

What problem does this PR solve?

This is a child PR of #2886

For details, please refer to #2860

What is changed and how it works?

  • mockcluster: support DisableFeature
  • raftcluster: remove unused RLock

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM HunDunDM added the component/cluster Cluster logic. label Sep 3, 2020
@HunDunDM HunDunDM self-assigned this Sep 3, 2020
@HunDunDM HunDunDM mentioned this pull request Sep 3, 2020
37 tasks
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 3, 2020
@disksing
Copy link
Contributor

disksing commented Sep 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@HunDunDM merge failed.

@HunDunDM
Copy link
Member Author

HunDunDM commented Sep 3, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@HunDunDM merge failed.

@disksing
Copy link
Contributor

disksing commented Sep 3, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d6a7c77 into tikv:master Sep 3, 2020
@HunDunDM HunDunDM deleted the joint/refine-mockcluster branch September 3, 2020 10:19
HunDunDM added a commit to HunDunDM/pd that referenced this pull request Sep 16, 2020
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Cluster logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants