metrics: add more metrics for region and store heartbeat #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhemingi
force-pushed
the
add-metric-in-handle-heartbeat
branch
from
c707e56
to
9952e16
Compare
|
Hi, would you mind taking a look to see if this pr meets your expectations ? |
Signed-off-by: Zheming Li <nkdudu@126.com>
lizhemingi
force-pushed
the
add-metric-in-handle-heartbeat
branch
from
aca4b30
to
5f16212
Compare
nolouch
reviewed
Sep 2, 2020
nolouch
reviewed
Sep 2, 2020
|
plz sign dco |
nolouch
added
the
needs-cherry-pick-release-4.0
|
@lhy1024 Should I also squash the commits ? |
|
it is not necessary to squash the commits, only to sign dco is enough. It will be squashed when merging pr |
lizhemingi
force-pushed
the
add-metric-in-handle-heartbeat
branch
from
fbc90e2
to
b568a5b
Compare
Signed-off-by: Zheming Li <nkdudu@126.com>
lizhemingi
force-pushed
the
add-metric-in-handle-heartbeat
branch
from
b568a5b
to
87b7530
Compare
lhy1024
reviewed
Sep 3, 2020
|
|
Signed-off-by: Zheming Li <nkdudu@126.com>
|
LGTM |
nolouch
approved these changes
Sep 3, 2020
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Sep 3, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@duduainankai merge failed. |
|
/merge |
|
/run-all-tests |
|
@duduainankai merge failed. |
|
/run-integration-lightning-test |
2 similar comments
|
/run-integration-lightning-test |
|
/run-integration-lightning-test |
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Sep 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2891 |
ti-srebot
added a commit
that referenced
this pull request
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zheming Li nkdudu@126.com
What problem does this PR solve?
Add more metrics about heartbeat. Solve #2800
What is changed and how it works?
Add heartbeat handle duration for region heartbeat and store heartbeat.
Add panel in pd grafana dashboard.
Fix RegionHeartBeat still count "ok" when error occurs.
Check List
Tests
Code changes
Release note